Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] fix commit check #7661

Merged
merged 1 commit into from
Jan 18, 2022
Merged

[server] fix commit check #7661

merged 1 commit into from
Jan 18, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jan 18, 2022

Fixes a left over case where we would ignore the new settings and always send 'success'.

Release Notes

NONE

@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 18, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-commit-check-fix.2

@svenefftinge svenefftinge requested a review from a team January 18, 2022 16:21
@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 18, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-commit-check-fix.3

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svenefftinge!

Approving because the code looks good to me. Didn't test it.

/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2f369fd44cff00de2d38ad5ca8e985fc1d123333

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue requirement bypassed by: jankeromnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #7661 (2f43469) into main (b5728fc) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7661      +/-   ##
==========================================
- Coverage   11.63%   10.38%   -1.26%     
==========================================
  Files          20       18       -2     
  Lines        1160      992     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1022      888     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5728fc...2f43469. Read the comment docs.

@svenefftinge svenefftinge merged commit ac0eeee into main Jan 18, 2022
@svenefftinge svenefftinge deleted the se/commit-check-fix branch January 18, 2022 16:36
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants