-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] fix commit check #7661
Conversation
17ac09a
to
2f43469
Compare
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-se-commit-check-fix.2 |
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-se-commit-check-fix.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svenefftinge!
Approving because the code looks good to me. Didn't test it.
/approve no-issue
LGTM label has been added. Git tree hash: 2f369fd44cff00de2d38ad5ca8e985fc1d123333
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes Associated issue requirement bypassed by: jankeromnes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #7661 +/- ##
==========================================
- Coverage 11.63% 10.38% -1.26%
==========================================
Files 20 18 -2
Lines 1160 992 -168
==========================================
- Hits 135 103 -32
+ Misses 1022 888 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fixes a left over case where we would ignore the new settings and always send 'success'.
Release Notes