Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Switch default log level to info #7660

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 18, 2022

Description

  • Default log level should be info
  • Add helper to serialize JSON and unify output format

How to test

Release Notes

[installer] Switch default log level to info

@roboquat roboquat added do-not-merge/release-note-label-needed team: IDE team: webapp Issue belongs to the WebApp team team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team size/M release-note and removed do-not-merge/release-note-label-needed labels Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #7660 (a3c8b15) into main (b5728fc) will decrease coverage by 3.75%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7660      +/-   ##
=========================================
- Coverage   11.63%   7.88%   -3.76%     
=========================================
  Files          20      31      +11     
  Lines        1160    2157     +997     
=========================================
+ Hits          135     170      +35     
- Misses       1022    1985     +963     
+ Partials        3       2       -1     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/common.go 4.61% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5728fc...a3c8b15. Read the comment docs.

@aledbf aledbf requested review from csweichel and mrsimonemms and removed request for csweichel January 18, 2022 14:59
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ff552245f708fb0e5c5b2a526e68c835b4b6d78

@mrsimonemms
Copy link
Contributor

/lgtm
/approve no-issue

@jeanp413
Copy link
Member

/lgtm

@jeanp413 jeanp413 self-requested a review January 18, 2022 18:14
@geropl
Copy link
Member

geropl commented Jan 19, 2022

/lgtm

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, geropl, jeanp413, MrSimonEmms

Associated issue requirement bypassed by: MrSimonEmms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 92a9fd5 into main Jan 19, 2022
@roboquat roboquat deleted the aledbf/updloglvl branch January 19, 2022 08:57
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production release-note size/M team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants