Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]: remove the deprecated TypeORM migration command #7642

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

The migrations:run command is now deprecated, replaced in favour of migration:run (singular, not plural).

For additional debugging, have also added in the "show" command to display the migration files that will show the migrations that will be applied.

Related Issue(s)

Fixes #7641

How to test

Deploy to werft and check migration job, within 60 seconds.

Release Notes

[Installer]: remove the deprecated TypeORM migration command

Documentation

The "migrations" command is now deprecated, replaced in favour of
"migration". Also added in the "show" command to display the migration
files that will show the migrations that will be applied.
@roboquat roboquat added release-note team: delivery Issue belongs to the self-hosted team size/XS labels Jan 17, 2022
@mrsimonemms mrsimonemms requested a review from a team January 17, 2022 15:33
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #7642 (9a2d528) into main (9cbfc06) will decrease coverage by 0.80%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #7642      +/-   ##
========================================
- Coverage   8.69%   7.88%   -0.81%     
========================================
  Files         33      31       -2     
  Lines       2323    2155     -168     
========================================
- Hits         202     170      -32     
+ Misses      2117    1983     -134     
+ Partials       4       2       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbfc06...9a2d528. Read the comment docs.

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d0dc3c2a139d0b4d9afa77d894cee433ce13701

@corneliusludmann
Copy link
Contributor

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue: #7641

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 3b4e7ec into main Jan 17, 2022
@mrsimonemms mrsimonemms deleted the sje/installer-migration-cmd branch January 17, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: remove the deprecated TypeORM migration command
3 participants