Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include in the README where to access the development environment when developing dashboards using gitpod #7581

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Jan 13, 2022

Signed-off-by: utam0k [email protected]

Description

I was a bit confused when I tried to start developing the dashboard, so I added a README to solve that.

Related Issue(s)

None

How to test

None

Release Notes

NONE

Documentation

No

…n developing dashboards using gitpod

Signed-off-by: utam0k <[email protected]>
@utam0k utam0k force-pushed the update-dashboard-readme branch from 61a2248 to 715b442 Compare January 13, 2022 06:52
@utam0k
Copy link
Contributor Author

utam0k commented Jan 13, 2022

Render

@iQQBot
Copy link
Contributor

iQQBot commented Jan 13, 2022

/werft run

👍 started the job as gitpod-build-update-dashboard-readme-fork.0

@utam0k
Copy link
Contributor Author

utam0k commented Jan 17, 2022

/werft run

👍 started the job as gitpod-build-update-dashboard-readme-fork.1

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #7581 (715b442) into main (f5c27bf) will decrease coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7581      +/-   ##
=========================================
- Coverage   10.81%   9.53%   -1.29%     
=========================================
  Files          20      18       -2     
  Lines        1248    1080     -168     
=========================================
- Hits          135     103      -32     
+ Misses       1110     976     -134     
+ Partials        3       1       -2     
Flag Coverage Δ
components-gitpod-cli-app 9.53% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c27bf...715b442. Read the comment docs.

@JanKoehnlein
Copy link
Contributor

/approve no-issue
/lgtm

Thanks for the PR!

In the future, please make sure your release-note is enclosed in triple backticks like this

```release-notes
NONE
```

otherwise our changelog parser doesn't recognise it.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94f9988a94e48974c9dadf55bfba5cc36a97dadf

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue requirement bypassed by: JanKoehnlein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f4115bc into gitpod-io:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants