Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Adjust probe InitialDelaySeconds #7512

Merged
merged 2 commits into from
Jan 12, 2022
Merged

[ws-manager] Adjust probe InitialDelaySeconds #7512

merged 2 commits into from
Jan 12, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 8, 2022

Description

Reduce the initial delay to start checking the status of the workspace

How to test

  • Workspaces should start without issues

Release Notes

[ws-manager] Adjust probe InitialDelaySeconds

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #7512 (6243d09) into main (3099765) will increase coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #7512      +/-   ##
========================================
+ Coverage   8.38%   9.53%   +1.15%     
========================================
  Files         33      18      -15     
  Lines       2410    1080    -1330     
========================================
- Hits         202     103      -99     
+ Misses      2204     976    -1228     
+ Partials       4       1       -3     
Flag Coverage Δ
components-gitpod-cli-app 9.53% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/common.go
installer/pkg/common/storage.go
installer/pkg/components/ws-manager/configmap.go
installer/pkg/common/render.go
installer/pkg/components/ws-manager/deployment.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/components/ws-manager/tlssecret.go
installer/pkg/common/objects.go
installer/pkg/components/ws-manager/rolebinding.go
components/local-app/pkg/auth/auth.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3099765...6243d09. Read the comment docs.

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cb2e86cd7a76e25b55a69d2ca4bb5e23b822145

@aledbf aledbf marked this pull request as ready for review January 12, 2022 18:58
@aledbf
Copy link
Member Author

aledbf commented Jan 12, 2022

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, kylos101

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 23cacbd into main Jan 12, 2022
@roboquat roboquat deleted the aledbf/probe branch January 12, 2022 18:59
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants