[installer]: use a pointer deref if the ssh gateway secret does not exist

[mrsimonemms]

Description

If no SSHGatewayHostKey is provided, the ws-proxy.deployment errored as was referencing the Name != "". To keep with the existing convention, this has been changed to SSHGatewayHostKey != nil as the validation ensures that the Name is populated

Related Issue(s)

Fixes issue raised in Discord

How to test

Render a k8s object with not SSHGatewayHostKey secret set

Release Notes

[installer]: use a pointer deref if the ssh gateway secret does not exist

Documentation

[codecov]

Codecov Report

Merging #7508 (64f11d3) into main (40b1c02) will decrease coverage by 3.23%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main   #7508      +/-   ##
=========================================
- Coverage   10.81%   7.58%   -3.24%     
=========================================
  Files          20      31      +11     
  Lines        1248    2242     +994     
=========================================
+ Hits          135     170      +35     
- Misses       1110    2070     +960     
+ Partials        3       2       -1     

Flag	Coverage Δ
components-gitpod-cli-app	9.53% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
installer-raw-app	5.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/common/ca.go	0.00% <0.00%> (ø)
installer/pkg/common/render.go	0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go	0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go	0.00% <0.00%> (ø)
installer/pkg/common/objects.go	0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go	29.71% <0.00%> (ø)
installer/pkg/common/common.go	4.64% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go	0.00% <0.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b1c02...64f11d3. Read the comment docs.

[iQQBot]

thanks, lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 346168d65cbca9465e95e3ce527a364668f08d6e

[iQQBot]

/approve no-issue

[mrsimonemms]

/approve no-issue

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot, MrSimonEmms

Associated issue requirement bypassed by: MrSimonEmms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• installer/pkg/components/ws-proxy/OWNERS [MrSimonEmms]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment