Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotfiles input help text design #7493

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Update dotfiles input help text design #7493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/dashboard/src/settings/Preferences.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ export default function Preferences() {
<div className="mt-4 max-w-md">
<h4>Repository URL</h4>
<input type="text" value={dotfileRepo} className="w-full" placeholder="e.g. https://github.com/username/dotfiles" onChange={(e) => setDotfileRepo(e.target.value)} />
<p className="text-base text-gray-500 dark:text-gray-400">Add a repository URL that includes dotfiles. Gitpod will clone and install your dotfiles for every new workspace.</p>
<div className="mt-1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You could add the mt-1 class to the <p/> element below, in order to avoid extra nesting. Not very important though.

Copy link
Contributor Author

@gtsiolis gtsiolis Jan 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, Tried to replicate the semantics structure we already use elsewhere:

gitpod/components/dashboard/src/settings/EnvironmentVariables.tsx

Lines 73 to 75 in e2c1988

<div className="mt-1">
<p className="text-gray-500">You can pass a variable for a specific project or use wildcard character (<CodeText>*/*</CodeText>) to make it available in more projects.</p>
</div>

Also, agree we could make this could be improved. Creating a reusable component for this form element could help. 💡

<p className="text-gray-500 dark:text-gray-400">Add a repository URL that includes dotfiles. Gitpod will clone and install your dotfiles for every new workspace.</p>
</div>
<div className="mt-4 max-w-md">
<button onClick={() => actuallySetDotfileRepo(dotfileRepo)}>Save Changes</button>
</div>
Expand Down