JB gateway plugin #7362

akosyakov · 2021-12-25T06:14:34Z

Description

This PR refactors JB integration to leverage SSH Gateway and enable client-to-server flow from JB Gateway, particularly:

fixing JB backend plugin
- remove dependencies, since JB backend already has Kotlin dependencies, and adding other version leads to runtime incompatibilities
- fix memory leak of grpc message channels
- use Kotlin koroutines instead of dedicated thread for heartbeating
- implement web socket reconnection handling for Gitpod server connection
- pin java target to v.11 in all projects
initial Gitpod plugin for JB Gateway that provides:
- connection over SSH gateway for jetbrains-gateway://connect?gitpodHost=<gitpodHost>&workspaceId=<workspaceId> links
- initial implementation of Gitpod UI in JB Gateway, i.e. welcome screen and recent projects view
switch JB images to use JB Gateway with Gitpod plugin in order to establish connection over SSH gateway not CWM links
add JB Plugins as client types for server tracing
resume hearbeating if window unload was cancelled in supervisor frontend on redirection to JB Gateway

Related Issue(s)

Fixes #5644, #7524

How to test

From Gitpod:

Go to preferences and switch to IntelliJ: https://ak-jb-gateway-plugin.staging.gitpod-dev.com/preferences
Start a workspace and check that you can connect.

From Gateway:

If you did above and everything was clear by now you should have JB Gateway installed.
Preferences... -> Tools -> Gitpod and point Gitpod Host to ak-jb-gateway-plugin.staging.gitpod-dev.com
Try to use Gateway to start workspaces from there using Gitpod UI.

Release Notes

- Refactor JB integration to connect over SSH instead of CWM links.
- Provide Gitpod integration in JB Gateway.

Documentation

akosyakov · 2021-12-28T06:37:33Z

/werft run

👍 started the job as gitpod-build-ak-jb-gateway-plugin.5

github-actions · 2021-12-29T10:31:24Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T10:32:02Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T10:33:31Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T10:56:25Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T11:04:59Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T11:10:33Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T13:34:18Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

github-actions · 2021-12-29T14:01:19Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

codecov · 2021-12-29T14:06:31Z

Codecov Report

Merging #7362 (a6764c4) into main (499ac3a) will decrease coverage by 1.26%.
The diff coverage is n/a.

❗ Current head a6764c4 differs from pull request most recent head 3953a45. Consider uploading reports for the commit 3953a45 to get more accurate results

@@            Coverage Diff             @@
##             main    #7362      +/-   ##
==========================================
- Coverage   11.46%   10.20%   -1.27%     
==========================================
  Files          20       18       -2     
  Lines        1177     1009     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1039      905     -134     
+ Partials        3        1       -2

Flag	Coverage Δ
components-gitpod-cli-app	`10.20% <ø> (ø)`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499ac3a...3953a45. Read the comment docs.

github-actions · 2021-12-29T15:16:21Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

roboquat · 2022-01-27T06:32:31Z

LGTM label has been added.

Git tree hash: 6568acefb0ea896c8298dd934c22e349a00b735b

iQQBot · 2022-01-27T07:36:10Z

I have tested this several times, including

repeatedly opening/closing
installing plug-ins that require a restart (Gateway will disconnect after 10 seconds of restart and then will not try to reconnect, but will need to open the connection page again or open again from the most recent connection, but this should not affect the process)
Looks good

akosyakov · 2022-01-27T07:39:27Z

@iQQBot @mustard-mh thank you, i asked to approve the current version of the plugin then

installing plug-ins that require a restart (Gateway will disconnect after 10 seconds of restart and then will not try to reconnect, but will need to open the connection page again or open again from the most recent connection, but this should not affect the process)

🙏 I will check it, something what I overlooked.

akosyakov · 2022-01-27T07:53:34Z

Gateway will disconnect after 10 seconds of restart and then will not try to reconnect, but will need to open the connection page again or open again from the most recent connection, but this should not affect the process

I could not reproduce. Maybe I need to throttle my connection for that, i.e. it is not reproducible on stable connection with low latency. Let's wait for issues from users then.

roboquat · 2022-01-27T07:57:40Z

New changes are detected. LGTM label has been removed.

github-actions · 2022-01-27T07:57:51Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

- remove dependencies, since JB backend already has Kotling dependencies, and adding other version leads to runtime incompatibilities - fix memory leak of grpc message channels - use Kotlin koroutines instead of dedicated thread for heartbeating - implement web socket reconnection handling for Gitpod server connection - pin java target to v.11 in all projects

github-actions · 2022-01-27T08:14:59Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

github-actions · 2022-01-27T08:21:36Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

It provides: - connection over SSH gateway for jetbrains-gateway://connect?gitpodHost=<gitpodHost>&workspaceId=<workspaceId> links - initial implementaiton of Gitpod UI in JB Gateway, i.e. welcome screen and recent projects view

in order to estable connection over SSH gateway not CWM links

github-actions · 2022-01-27T08:31:27Z

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

akosyakov · 2022-01-27T09:05:50Z

/unhold

roboquat · 2022-01-27T09:14:58Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: iQQBot, jankeromnes

Associated issue: #5644

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [iQQBot,jankeromnes]
~~components/gitpod-protocol/java/OWNERS~~ [iQQBot]
~~components/ide/OWNERS~~ [iQQBot]
~~components/server/OWNERS~~ [jankeromnes]
~~components/supervisor/OWNERS~~ [iQQBot]
components/supervisor-api/OWNERS
~~installer/pkg/components/server/ide/OWNERS~~ [iQQBot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed team: webapp Issue belongs to the WebApp team size/M team: IDE size/XXL and removed size/M labels Dec 25, 2021

akosyakov force-pushed the ak/jb_gateway_plugin branch 2 times, most recently from 3f14d91 to 9f47d83 Compare December 27, 2021 08:58

akosyakov force-pushed the ak/jb_gateway_plugin branch 3 times, most recently from 266a382 to 61560f4 Compare December 29, 2021 10:26

roboquat added the team: workspace Issue belongs to the Workspace team label Dec 29, 2021

akosyakov force-pushed the ak/jb_gateway_plugin branch 2 times, most recently from 266a382 to 1e83ff3 Compare December 29, 2021 10:31

akosyakov force-pushed the ak/jb_gateway_plugin branch from 1e83ff3 to e21109e Compare December 29, 2021 10:31

akosyakov force-pushed the ak/jb_gateway_plugin branch from e21109e to 8b6b98f Compare December 29, 2021 10:33

akosyakov force-pushed the ak/jb_gateway_plugin branch from 8b6b98f to 220bba4 Compare December 29, 2021 10:56

akosyakov force-pushed the ak/jb_gateway_plugin branch from 220bba4 to 91df848 Compare December 29, 2021 11:04

roboquat added the lgtm label Jan 27, 2022

akosyakov force-pushed the ak/jb_gateway_plugin branch from 30254ab to a132d6b Compare January 27, 2022 07:57

roboquat removed the lgtm label Jan 27, 2022

akosyakov added 2 commits January 27, 2022 09:14

[gitpod-protocol] exposing APIs required for JB integration

d472d6d

akosyakov force-pushed the ak/jb_gateway_plugin branch from a132d6b to 903df7d Compare January 27, 2022 08:14

akosyakov force-pushed the ak/jb_gateway_plugin branch from 903df7d to dc65db3 Compare January 27, 2022 08:21

akosyakov added 4 commits January 27, 2022 09:30

initial commit of Gitpod pugin for JB Gateway

44ecd32

It provides: - connection over SSH gateway for jetbrains-gateway://connect?gitpodHost=<gitpodHost>&workspaceId=<workspaceId> links - initial implementaiton of Gitpod UI in JB Gateway, i.e. welcome screen and recent projects view

switch JB images to use JB Gatway with Gitpod plugin

ae066f3

in order to estable connection over SSH gateway not CWM links

[server] add JB plugins as client types for tracing

bb29e64

[supervisor] resume hearbeating if window unload was cancelled

3953a45

akosyakov force-pushed the ak/jb_gateway_plugin branch from dc65db3 to 3953a45 Compare January 27, 2022 08:31

roboquat removed the do-not-merge/hold label Jan 27, 2022

akosyakov added lgtm approved labels Jan 27, 2022

roboquat merged commit 84a496d into main Jan 27, 2022

roboquat deleted the ak/jb_gateway_plugin branch January 27, 2022 09:15

akosyakov mentioned this pull request Jan 27, 2022

First iteration gateway tile implementation (minimal) #7524

Closed

roboquat added the deployed: workspace Workspace team change is running in production label Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JB gateway plugin #7362

JB gateway plugin #7362

akosyakov commented Dec 25, 2021 •

edited

Loading

akosyakov commented Dec 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

codecov bot commented Dec 29, 2021 •

edited

Loading

github-actions bot commented Dec 29, 2021

roboquat commented Jan 27, 2022

iQQBot commented Jan 27, 2022

akosyakov commented Jan 27, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Jan 27, 2022 •

edited

Loading

roboquat commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

akosyakov commented Jan 27, 2022

roboquat commented Jan 27, 2022

JB gateway plugin #7362

JB gateway plugin #7362

Conversation

akosyakov commented Dec 25, 2021 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

akosyakov commented Dec 28, 2021 • edited by werft-gitpod-dev-com bot Loading

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

github-actions bot commented Dec 29, 2021

codecov bot commented Dec 29, 2021 • edited Loading

Codecov Report

github-actions bot commented Dec 29, 2021

roboquat commented Jan 27, 2022

iQQBot commented Jan 27, 2022

akosyakov commented Jan 27, 2022 • edited by werft-gitpod-dev-com bot Loading

akosyakov commented Jan 27, 2022 • edited Loading

roboquat commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

github-actions bot commented Jan 27, 2022

akosyakov commented Jan 27, 2022

roboquat commented Jan 27, 2022

akosyakov commented Dec 25, 2021 •

edited

Loading

akosyakov commented Dec 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Dec 29, 2021 •

edited

Loading

akosyakov commented Jan 27, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Jan 27, 2022 •

edited

Loading