Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] update stable to 1.63 #7133

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[code] update stable to 1.63 #7133

merged 1 commit into from
Dec 9, 2021

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Dec 9, 2021

  • /werft with-clean-slate-deployment

Description

Updates stable VS Code Web to 1.63

Related Issue(s)

Fixes #

How to test

  • Select vscode stable in dashboard settings
  • Start a workspace.
  • Use about dialog to check that version is 1.63.

Release Notes

Update VS Code Web to 1.63

Documentation

@jeanp413
Copy link
Member Author

jeanp413 commented Dec 9, 2021

@akosyakov It's failing to open a workspace I'm getting 401 error when selecting vscode stable, insiders works fine. I created another PR because the first one #7132 had the same url in werft with this one #7112 (weft ignored anything after the . in the branch name). Could this be related to the 401 error?

@akosyakov
Copy link
Member

akosyakov commented Dec 9, 2021

@jeanp413 Can we take it from production for nightly instead? It does look like incorrect image. In production insider points to nightly@sha256:6f945df7cd71a481e3bb7eac5619c63dfeb65bff6001899d10d4899eb13a3ca2

Actually even better if we look at server logs in this prev env we can see to which version insider is resolved and it is: commit-4cf15538da2ecff8bae9245f18aa3ac6f3b90c3f (corresponding to this commit)

@jeanp413 jeanp413 force-pushed the jp/vscode-stable-1.63 branch from 4000f16 to 4dbf6d3 Compare December 9, 2021 15:09
@jeanp413
Copy link
Member Author

jeanp413 commented Dec 9, 2021

/werft run

👍 started the job as gitpod-build-jp-vscode-stable-1.63.2

@akosyakov
Copy link
Member

/approve
/lgtm

Insiders and stable are served from the same commit, so we merge it.

@roboquat
Copy link
Contributor

roboquat commented Dec 9, 2021

LGTM label has been added.

Git tree hash: 08cf9925aa73941ce59f8909e74dcc23cc05c09d

@akosyakov
Copy link
Member

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Dec 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 36c89b6 into main Dec 9, 2021
@roboquat roboquat deleted the jp/vscode-stable-1.63 branch December 9, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants