[projects] remove configuration page from wizard #7102

AlexTugarev · 2021-12-07T11:01:58Z

instead of showing the configuration page, let's show a simple New Workspace button to start a workspace.

we rescue the auto-inferred configuration or use the existing one to trigger a prebuild right away.

many thanks to @jankeromnes to help get this done! 💯

Projects: remove the configuration page from New Project wizard.

jldec · 2021-12-07T12:14:25Z

Please see also #7088 and #7098

AlexTugarev · 2021-12-07T12:27:11Z

/werft help

👍 You can interact with werft using: /werft command <args>.
Available commands are:

/werft run [annotation=value] which starts a new werft job from this context.
You can optionally pass multiple whitespace-separated annotations.
/werft help displays this help

jldec · 2021-12-07T12:28:11Z

comments on the current implementation

The link in the text at the top goes to /new
The text below the button is a bit confusing
not all users will understand that it explains what the button is going to do.

AlexTugarev · 2021-12-07T12:33:41Z

I had to redeploy the whole thing. Workspaces failed to start after a rebase, unfortunately.

AlexTugarev · 2021-12-07T12:56:33Z

/werft run

👍 started the job as gitpod-build-at-config-page.8

jldec · 2021-12-07T18:06:07Z

I think for consistency, and to help users, we need 1 line of explanatory text (in smaller, lighter font) under the project created. @gtsiolis would you mind taking a look, and letting us know what you think?

Otherwise I think this resolves both #7088 and #7098

jldec · 2021-12-07T18:42:02Z

Another idea - with links to project and team (project list)

AlexTugarev · 2021-12-08T08:53:05Z

@jldec, it's updated, and build is triggered. Please note, workspaces do fail to start on preview environments at the moment. That's nothing to be part of this PR.

jankeromnes · 2021-12-08T13:46:03Z

components/dashboard/src/projects/NewProject.tsx

+                        setSourceOfConfig("db");
+                        setGuessedConfigString(await guessedConfigStringPromise || `tasks:
+  - init: |
+      echo 'TODO: build project'
+    command: |
+      echo 'TODO: start app'`);


I think there can be a race here -- if await guessedConfigStringPromise takes too long, you might call server.setProjectConfiguration(project.id, undefined) on line 154.

Safer the other way around:

Suggested change

setSourceOfConfig("db");

setGuessedConfigString(await guessedConfigStringPromise || `tasks:

- init: |

echo 'TODO: build project'

command: |

echo 'TODO: start app'`);

setGuessedConfigString(await guessedConfigStringPromise || `tasks:

- init: |

echo 'TODO: build project'

command: |

echo 'TODO: start app'`);

setSourceOfConfig("db");

components/dashboard/src/projects/NewProject.tsx

jankeromnes · 2021-12-08T13:51:42Z

components/dashboard/src/projects/NewProject.tsx

+                <p className="mt-2 text-gray-500 text-center text-base">Created <a className="gp-link" href={projectLink}>{project.name}</a>
+                    <br /> {location}


Nit: This deviates slightly from the spec, but I'd find it a lot better to explicitly state what's a "project" and what's a "team", just to avoid any possible confusion here (as we've seen in user testing, users are sometimes confused between workspace vs team vs project, so might as well be 100% clear here).

Also, the new line between the two doesn't make sense, and actually looks like a UI bug:

Suggested change

<p className="mt-2 text-gray-500 text-center text-base">Created <a className="gp-link" href={projectLink}>{project.name}</a>

<br /> {location}

<p className="mt-2 text-gray-500 text-center text-base">Created project <a className="gp-link" href={projectLink}>{project.name}</a> {location}

which spec do you mean? cf. https://gitpod.slack.com/archives/C02EN94AEPL/p1638903077402500?thread_ts=1638877444.381700&cid=C02EN94AEPL

To me, spec = visuals added to an issue that show what we want to have.

Here, it's #7098 (see "refined visual" at the bottom of the issue description)

However, I slightly disagree with the spec, because I think:

Project Created Created project [test-project-2] in team [team-1]

is clearer than:

Project created Created [test-project-2] in [team-1]

components/dashboard/src/projects/NewProject.tsx

codecov · 2021-12-08T13:55:55Z

Codecov Report

Merging #7102 (baa41ec) into main (34e4dcb) will increase coverage by 12.42%.
The diff coverage is n/a.

❗ Current head baa41ec differs from pull request most recent head 9030481. Consider uploading reports for the commit 9030481 to get more accurate results

@@             Coverage Diff             @@
##             main    #7102       +/-   ##
===========================================
+ Coverage   19.04%   31.47%   +12.42%     
===========================================
  Files           2       28       +26     
  Lines         168     4823     +4655     
===========================================
+ Hits           32     1518     +1486     
- Misses        134     3187     +3053     
- Partials        2      118      +116

Flag	Coverage Δ
components-local-app-app-linux-amd64	`19.04% <0.00%> (ø)`
components-local-app-app-linux-arm64	`∅ <0.00%> (∅)`
components-local-app-app-windows-386	`∅ <0.00%> (∅)`
components-local-app-app-windows-amd64	`∅ <0.00%> (∅)`
components-local-app-app-windows-arm64	`∅ <0.00%> (∅)`
components-ws-manager-app	`40.62% <0.00%> (?)`
installer-raw-app	`5.76% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
installer/pkg/components/ws-manager/tlssecret.go	`0.00% <0.00%> (ø)`
components/ws-manager/pkg/manager/create.go	`82.98% <0.00%> (ø)`
installer/pkg/common/objects.go	`0.00% <0.00%> (ø)`
components/ws-manager/pkg/manager/probe.go	`0.00% <0.00%> (ø)`
installer/pkg/components/ws-manager/rolebinding.go	`0.00% <0.00%> (ø)`
components/ws-manager/pkg/manager/manager_ee.go	`0.00% <0.00%> (ø)`
components/ws-manager/pkg/clock/clock.go	`68.62% <0.00%> (ø)`
installer/pkg/common/common.go	`4.64% <0.00%> (ø)`
installer/pkg/components/ws-manager/configmap.go	`29.71% <0.00%> (ø)`
components/ws-manager/pkg/manager/monitor.go	`9.46% <0.00%> (ø)`
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e4dcb...9030481. Read the comment docs.

instead of showing the configuration page, let's show a simple `New Workspace` button to start a workspace. we rescue the auto-inferred configuration or use the existing one to trigger a prebuild right away. Co-authored-by: Jan Keromnes <[email protected]> Co-authored-by: Alex Tugarev <[email protected]>

jldec · 2021-12-08T16:12:40Z

put some comments in #7098 (comment)
but happy to push this forward now - thanks @AlexTugarev and @jankeromnes

/lgtm

roboquat · 2021-12-08T16:12:44Z

LGTM label has been added.

Git tree hash: a17be6f3e98c535a7f152f53898151565c09af6c

roboquat · 2021-12-08T16:12:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #7098

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [jldec]
~~components/gitpod-protocol/OWNERS~~ [jldec]
~~components/server/OWNERS~~ [jldec]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

components/dashboard/src/projects/NewProject.tsx

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed team: webapp Issue belongs to the WebApp team size/L release-note and removed do-not-merge/release-note-label-needed labels Dec 7, 2021

AlexTugarev force-pushed the at/config-page branch 3 times, most recently from f8cb1cb to ea98254 Compare December 7, 2021 11:41

AlexTugarev marked this pull request as ready for review December 7, 2021 11:41

roboquat removed the do-not-merge/work-in-progress label Dec 7, 2021

AlexTugarev requested review from jankeromnes, gtsiolis and jldec December 7, 2021 11:42

AlexTugarev force-pushed the at/config-page branch from ea98254 to 3312ee5 Compare December 7, 2021 12:29

AlexTugarev force-pushed the at/config-page branch 2 times, most recently from bce4aa2 to 33734f0 Compare December 7, 2021 16:30

jldec mentioned this pull request Dec 7, 2021

Remove configuration step from new project onboarding flow #7088

Closed

AlexTugarev force-pushed the at/config-page branch from 33734f0 to 82d3603 Compare December 8, 2021 08:51

AlexTugarev force-pushed the at/config-page branch from 82d3603 to 49b28c4 Compare December 8, 2021 08:53

jankeromnes reviewed Dec 8, 2021

View reviewed changes

components/dashboard/src/projects/NewProject.tsx Outdated Show resolved Hide resolved

jankeromnes reviewed Dec 8, 2021

View reviewed changes

components/dashboard/src/projects/NewProject.tsx Outdated Show resolved Hide resolved

AlexTugarev force-pushed the at/config-page branch from 49b28c4 to 0cae03d Compare December 8, 2021 15:04

AlexTugarev force-pushed the at/config-page branch from 0cae03d to 9030481 Compare December 8, 2021 15:06

roboquat assigned jldec Dec 8, 2021

roboquat added the lgtm label Dec 8, 2021

roboquat added the approved label Dec 8, 2021

roboquat merged commit a481e8b into main Dec 8, 2021

roboquat deleted the at/config-page branch December 8, 2021 16:13

jankeromnes reviewed Dec 8, 2021

View reviewed changes

components/dashboard/src/projects/NewProject.tsx Show resolved Hide resolved

jankeromnes mentioned this pull request Dec 8, 2021

[dashboard] Fix possible race condition when creating a new project #7127

Merged

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[projects] remove configuration page from wizard #7102

[projects] remove configuration page from wizard #7102

AlexTugarev commented Dec 7, 2021 •

edited

Loading

jldec commented Dec 7, 2021

AlexTugarev commented Dec 7, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jldec commented Dec 7, 2021 •

edited

Loading

AlexTugarev commented Dec 7, 2021

AlexTugarev commented Dec 7, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jldec commented Dec 7, 2021

jldec commented Dec 7, 2021

AlexTugarev commented Dec 8, 2021

jankeromnes Dec 8, 2021

jankeromnes Dec 8, 2021

AlexTugarev Dec 8, 2021

jankeromnes Dec 8, 2021 •

edited

Loading

codecov bot commented Dec 8, 2021 •

edited

Loading

jldec commented Dec 8, 2021

roboquat commented Dec 8, 2021

roboquat commented Dec 8, 2021

		<p className="mt-2 text-gray-500 text-center text-base">Created <a className="gp-link" href={projectLink}>{project.name}</a>
		<br /> {location}

[projects] remove configuration page from wizard #7102

[projects] remove configuration page from wizard #7102

Conversation

AlexTugarev commented Dec 7, 2021 • edited Loading

jldec commented Dec 7, 2021

AlexTugarev commented Dec 7, 2021 • edited by werft-gitpod-dev-com bot Loading

jldec commented Dec 7, 2021 • edited Loading

AlexTugarev commented Dec 7, 2021

AlexTugarev commented Dec 7, 2021 • edited by werft-gitpod-dev-com bot Loading

jldec commented Dec 7, 2021

jldec commented Dec 7, 2021

AlexTugarev commented Dec 8, 2021

jankeromnes Dec 8, 2021

Choose a reason for hiding this comment

jankeromnes Dec 8, 2021

Choose a reason for hiding this comment

AlexTugarev Dec 8, 2021

Choose a reason for hiding this comment

jankeromnes Dec 8, 2021 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Dec 8, 2021 • edited Loading

Codecov Report

jldec commented Dec 8, 2021

roboquat commented Dec 8, 2021

roboquat commented Dec 8, 2021

AlexTugarev commented Dec 7, 2021 •

edited

Loading

AlexTugarev commented Dec 7, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jldec commented Dec 7, 2021 •

edited

Loading

AlexTugarev commented Dec 7, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes Dec 8, 2021 •

edited

Loading

codecov bot commented Dec 8, 2021 •

edited

Loading