Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust success criteria dashboard grouping period #6971

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 29, 2021

Description

Grouping by a period of 30 days means we don't see anything any meaningful trend in case of an incident.

Release Notes

Adjust success criteria dashboard grouping period

Documentation

@aledbf aledbf requested a review from csweichel November 29, 2021 19:06
@roboquat roboquat added team: workspace Issue belongs to the Workspace team size/XS labels Nov 29, 2021
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc95e833f6716eee162cb4419126dacaf3e7de8f

@aledbf
Copy link
Member Author

aledbf commented Nov 30, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 93ed40d into main Nov 30, 2021
@roboquat roboquat deleted the aledbf/dash branch November 30, 2021 14:07
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants