-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: remove jaeger operator external #6964
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6964 +/- ##
==========================================
- Coverage 19.04% 5.84% -13.21%
==========================================
Files 2 13 +11
Lines 168 1147 +979
==========================================
+ Hits 32 67 +35
- Misses 134 1079 +945
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Does this require any change in our sample config files for installer? |
@princerachit my expectation is no. To the best of my knowledge, this is something that has never been used anywhere - I discovered this yesterday with @kylos101 with him going through his core-dev work |
LGTM label has been added. Git tree hash: 13bb949f162fac06dbd32203a191aaceb33fdd4f
|
Description
The
jaegerOperator
external object doesn't make any sense in it's current form. The Jaeger operators are all about installing Custom Resource Definitions and are not a resource that can be communicated with, which is what theexternal
objects have been used forRelease Notes
Documentation