Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart/template: Fix tracing endpoint variable #6933

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Nov 26, 2021

Description

The issue is never where we think it is 😅.

Turns out https://github.com/gitpod-io/ops/pull/347 didn't work because of a typo at our chart. I've already checked and we don't use tracing.endoint anywhere else, so it should be safe to merge.

Pinging @mrsimonemms and @csweichel because on today's Tech talk you've mentioned that changes to our chart probably require changes to the installer as well

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/340

How to test

Release Notes

Fix typo at Gitpod's helm chart

@mrsimonemms
Copy link
Contributor

@ArthurSens thanks for the notification. I don't think we need to make a change to the Installer just yet - there's an object in the Installer config for observability with an option tracing.endpoint part. This is an example:

observability:
  logLevel: info
  tracing: ## This is optional
    endpoint: http://jaeger-collector:14268/api/traces

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: c9d6613c561a6a476f9c593e8109eb075fceca4e

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #6933 (bf8c7a3) into main (3a965de) will decrease coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #6933      +/-   ##
========================================
- Coverage   7.52%   5.84%   -1.69%     
========================================
  Files         15      13       -2     
  Lines       1315    1147     -168     
========================================
- Hits          99      67      -32     
+ Misses      1213    1079     -134     
+ Partials       3       1       -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a965de...bf8c7a3. Read the comment docs.

@geropl
Copy link
Member

geropl commented Nov 29, 2021

/approve

@geropl
Copy link
Member

geropl commented Nov 29, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57224aff327aac3ad9526ff58c1784d2b5d6b5e5

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, mads-hartmann

Associated issue: #340

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 9751e42 into main Nov 29, 2021
@roboquat roboquat deleted the ArthurSens-patch-1 branch November 29, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants