-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart/template: Fix tracing endpoint variable #6933
Conversation
186b57f
to
e81ae35
Compare
@ArthurSens thanks for the notification. I don't think we need to make a change to the Installer just yet - there's an object in the Installer config for observability:
logLevel: info
tracing: ## This is optional
endpoint: http://jaeger-collector:14268/api/traces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
LGTM label has been added. Git tree hash: c9d6613c561a6a476f9c593e8109eb075fceca4e
|
Signed-off-by: ArthurSens <[email protected]>
e81ae35
to
bf8c7a3
Compare
Codecov Report
@@ Coverage Diff @@
## main #6933 +/- ##
========================================
- Coverage 7.52% 5.84% -1.69%
========================================
Files 15 13 -2
Lines 1315 1147 -168
========================================
- Hits 99 67 -32
+ Misses 1213 1079 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/approve |
/lgtm |
LGTM label has been added. Git tree hash: 57224aff327aac3ad9526ff58c1784d2b5d6b5e5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geropl, mads-hartmann Associated issue: #340 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The issue is never where we think it is 😅.
Turns out https://github.com/gitpod-io/ops/pull/347 didn't work because of a typo at our chart. I've already checked and we don't use
tracing.endoint
anywhere else, so it should be safe to merge.Pinging @mrsimonemms and @csweichel because on today's Tech talk you've mentioned that changes to our chart probably require changes to the installer as well
Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/340
How to test
Release Notes