-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: set all internal certs to 90 days duration #6893
Conversation
/lgtm |
LGTM label has been added. Git tree hash: 58bdd206b10b240bfc8ada3e8557f5afa430cfdb
|
@mrsimonemms, what happens in the components? The new certs are used? |
@aledbf I don't believe I've changed anything with the issuing of certs, just set a consistent duration |
/werft run no-preview 👍 started the job as gitpod-build-sje-installer-cert-duration.1 |
Codecov Report
@@ Coverage Diff @@
## main #6893 +/- ##
==========================================
- Coverage 19.04% 5.84% -13.21%
==========================================
Files 2 13 +11
Lines 168 1147 +979
==========================================
+ Hits 32 67 +35
- Misses 134 1079 +945
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5ceb2ee
to
ff11b98
Compare
/lgtm |
LGTM label has been added. Git tree hash: d38f484b60a63fc7dd8b9a9ef4c5ed08c767ad12
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel Associated issue: #6820 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Give all internal certs a consistent 90 day duration (I chose this figure as it's what LetsEncrypt does - happy to change if necessary).
Did this after setting all certs to a duration of 1 hour to prove that they auto-renew, which they do.
Related Issue(s)
Fixes #6820
How to test
Deploy the installer
Release Notes
Documentation