Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: set all internal certs to 90 days duration #6893

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

Give all internal certs a consistent 90 day duration (I chose this figure as it's what LetsEncrypt does - happy to change if necessary).

Did this after setting all certs to a duration of 1 hour to prove that they auto-renew, which they do.

Related Issue(s)

Fixes #6820

How to test

Deploy the installer

Release Notes

Set internal certs to 90 day duration

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team labels Nov 25, 2021
@mrsimonemms mrsimonemms requested review from csweichel and aledbf and removed request for csweichel November 25, 2021 11:26
@aledbf
Copy link
Member

aledbf commented Nov 25, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58bdd206b10b240bfc8ada3e8557f5afa430cfdb

@aledbf
Copy link
Member

aledbf commented Nov 25, 2021

@mrsimonemms, what happens in the components? The new certs are used?

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Nov 25, 2021

@aledbf I don't believe I've changed anything with the issuing of certs, just set a consistent duration

@csweichel
Copy link
Contributor

csweichel commented Nov 26, 2021

/werft run no-preview

👍 started the job as gitpod-build-sje-installer-cert-duration.1

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #6893 (ff11b98) into main (91dcd03) will decrease coverage by 13.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6893       +/-   ##
==========================================
- Coverage   19.04%   5.84%   -13.21%     
==========================================
  Files           2      13       +11     
  Lines         168    1147      +979     
==========================================
+ Hits           32      67       +35     
- Misses        134    1079      +945     
+ Partials        2       1        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b6154...ff11b98. Read the comment docs.

@mrsimonemms mrsimonemms force-pushed the sje/installer-cert-duration branch from 5ceb2ee to ff11b98 Compare November 26, 2021 09:54
@roboquat roboquat removed the lgtm label Nov 26, 2021
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d38f484b60a63fc7dd8b9a9ef4c5ed08c767ad12

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue: #6820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f8e9168 into main Nov 26, 2021
@roboquat roboquat deleted the sje/installer-cert-duration branch November 26, 2021 10:02
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: internal certificate validation
4 participants