-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use forked Minio charts #6892
Use forked Minio charts #6892
Conversation
98c0365
to
a78f16d
Compare
/hold |
a78f16d
to
8d2c118
Compare
/werft run no-preview 👍 started the job as gitpod-build-sje-minio-chart-6876.3 |
/approve no-issue |
LGTM label has been added. Git tree hash: 2eb0c3cd45e7325c4d9b446d90b22290f16aae71
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6876 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #6892 +/- ##
===========================================
+ Coverage 19.04% 32.06% +13.01%
===========================================
Files 2 26 +24
Lines 168 4647 +4479
===========================================
+ Hits 32 1490 +1458
- Misses 134 3040 +2906
- Partials 2 117 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
Minio removed their chart overnight. This replaces it with a forked version of the chart.
Ideally, I would have changed to using the Bitnami Minio chart as has been done in the Installer. However, this requires a change of values from
minio.accessKey
andminio.secretKey
tominio.auth.rootUser
andminio.auth.rootPassword
. From a testability/documentation/speed point of view, I took the view that this was too big a change and would require changes in Core Dev, Staging and Production. Using a fork at least keeps the change simpleRelated Issue(s)
Fixes #6876
How to test
Use Core Dev
Release Notes
Documentation