Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked Minio charts #6892

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Use forked Minio charts #6892

merged 1 commit into from
Nov 25, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

Minio removed their chart overnight. This replaces it with a forked version of the chart.

Ideally, I would have changed to using the Bitnami Minio chart as has been done in the Installer. However, this requires a change of values from minio.accessKey and minio.secretKey to minio.auth.rootUser and minio.auth.rootPassword. From a testability/documentation/speed point of view, I took the view that this was too big a change and would require changes in Core Dev, Staging and Production. Using a fork at least keeps the change simple

Related Issue(s)

Fixes #6876

How to test

Use Core Dev

Release Notes

Change Minio to forked version

Documentation

@mrsimonemms
Copy link
Contributor Author

/hold

@csweichel
Copy link
Contributor

csweichel commented Nov 25, 2021

/werft run no-preview

👍 started the job as gitpod-build-sje-minio-chart-6876.3

@csweichel
Copy link
Contributor

/approve no-issue
/lgtm
/hold cancel

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2eb0c3cd45e7325c4d9b446d90b22290f16aae71

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6876

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 320ea98 into main Nov 25, 2021
@roboquat roboquat deleted the sje/minio-chart-6876 branch November 25, 2021 11:08
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #6892 (8d2c118) into main (f07f8fd) will increase coverage by 13.01%.
The diff coverage is 18.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6892       +/-   ##
===========================================
+ Coverage   19.04%   32.06%   +13.01%     
===========================================
  Files           2       26       +24     
  Lines         168     4647     +4479     
===========================================
+ Hits           32     1490     +1458     
- Misses        134     3040     +2906     
- Partials        2      117      +115     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 40.66% <85.18%> (?)
installer-raw-app 5.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/monitor.go 9.46% <0.00%> (ø)
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 82.95% <100.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/ws-manager/pkg/manager/status.go 74.95% <0.00%> (ø)
...-manager/pkg/manager/internal/workpool/workpool.go 100.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348d534...8d2c118. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minio Helm chart dependency no longer available (or is offline)
3 participants