Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-proxy] Improve TLS default configuration #6870

Merged
merged 2 commits into from
Nov 25, 2021
Merged

[ws-proxy] Improve TLS default configuration #6870

merged 2 commits into from
Nov 25, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 24, 2021

Description

The default configuration should not allow TLSv1.0 or TLSv1.1

Note: this can be seen only in workspace clusters.

Release Notes

[ws-proxy] Improve TLS default configuration

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team labels Nov 24, 2021
@aledbf
Copy link
Member Author

aledbf commented Nov 24, 2021

ssl-from

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #6870 (9cca38d) into main (a36fd97) will increase coverage by 18.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6870       +/-   ##
===========================================
+ Coverage   19.04%   37.90%   +18.85%     
===========================================
  Files           2       20       +18     
  Lines         168     2203     +2035     
===========================================
+ Hits           32      835      +803     
- Misses        134     1317     +1183     
- Partials        2       51       +49     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-proxy-app 68.26% <0.00%> (?)
installer-raw-app 6.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-proxy/pkg/proxy/proxy.go 23.61% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/routes.go 82.99% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/auth.go 100.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36fd97...9cca38d. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Nov 24, 2021

ssl-after

@corneliusludmann
Copy link
Contributor

/approve

@corneliusludmann corneliusludmann removed their request for review November 25, 2021 09:39
@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Nov 25, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa13d4497c996b40f1949492e9cf4feb35123c3e

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann, csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 915cd41 into main Nov 25, 2021
@roboquat roboquat deleted the aledbf/ws-proxy branch November 25, 2021 14:55
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production release-note size/L team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants