Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-builder] Don't re-use authentication across requests #6860

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

csweichel
Copy link
Contributor

Description

This PR fixes authentication issues with bob proxy caused by invalid re-use of the Docker authorizer.

Related Issue(s)

Fixes #6849

How to test

Try to push an image to a private Azure registry through bob proxy.

Release Notes

[image-builder] Fix authentication issues with external registries

@roboquat roboquat added size/M and removed size/S labels Nov 24, 2021
@csweichel csweichel added the team: workspace Issue belongs to the Workspace team label Nov 24, 2021
@mrsimonemms
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Nov 24, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb57b967afd034968704748b223af8b65b29c4d9

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrSimonEmms

Associated issue: #6849

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0075756 into main Nov 24, 2021
@roboquat roboquat deleted the cw/fix-6849 branch November 24, 2021 09:27
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[image-builder-bob]: cannot authenticate against external registries
3 participants