Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-builder-mk3]: set x-forwarded-for header value to 127.0.0.1 #6836

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

Setting the X-Forwarded-For value to 127.0.0.1 ensures that an IPv4 address is returned from the container registry authentication protocol. With docker.com for example, if IPv6 is enabled, it returns the URL auth.ipv6.docker.com which appears not to be a valid subdomain.

How to test

Release Notes

Set the x-forwarded-for value to `127.0.0.1` to prevent container registry auth errors

Documentation

@mrsimonemms
Copy link
Contributor Author

/assign @csweichel

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat roboquat added the lgtm label Nov 22, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: f97f7cd234112bbea8e3eb713df88a66f04c96b7

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 6793883 into main Nov 22, 2021
@roboquat roboquat deleted the sje/imagebuilder-x-forward-header branch November 22, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants