-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: validate the AuthProvider config value #6753
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6753 +/- ##
==========================================
- Coverage 19.04% 6.16% -12.88%
==========================================
Files 2 12 +10
Lines 168 1086 +918
==========================================
+ Hits 32 67 +35
- Misses 134 1018 +884
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrsimonemms just a question Re: conditional validation support in Go - thanks for the heads up! Let me know your preference?
Adds the id, host and type params to the AuthProvider and also adds validation on the required fields
b467bb8
to
5038c84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrsimonemms nice work, amigo! Have a good rest of your evening. 🌃
LGTM label has been added. Git tree hash: bd18bf85faaa29856689d38751997e64be0490bc
|
/approve |
/approve no-issue |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kylos101, MrSimonEmms Associated issue: #6750 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Gets the auth provider config working. Adds the id, host and type params to the AuthProvider and also adds validation on the required fields
Related Issue(s)
Fixes #6750
How to test
Run installer with config:
Remove one of the ones marked
required
in there and the validation should failRelease Notes
Documentation