-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Installer]: configure minio to act as gateway to azure blob storage #6745
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6745 +/- ##
==========================================
- Coverage 19.04% 6.21% -12.84%
==========================================
Files 2 12 +10
Lines 168 1078 +910
==========================================
+ Hits 32 67 +35
- Misses 134 1010 +876
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3f5ec1d
to
f7d5fd8
Compare
/assign @csweichel |
} | ||
|
||
if pointer.BoolDeref(ctx.Config.ObjectStorage.InCluster, false) { | ||
if useMinio(ctx) { | ||
// builtin storage needs no extra mounts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all useMinio
cases internal storage only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minio can be in two states - internal storage and gateway to external. Because the interface is the same, we don't actually need to know how we're doing it, just that we are doing it.
This is how it seems to work with Helm (so what I've replicated in Installer), that the storage is either GCP or Minio, regardless of whether Minio is internal or gateway.
In the future (#6777), there will be an additional "if s3" in the useMinio
function. As there are two places where we need to know if we're using Minio (and not how we're using it), it seemed sensible to have a function to work it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes a total sense. I was just a tad confused by the comment in this line.
f7d5fd8
to
0186808
Compare
/lgtm |
LGTM label has been added. Git tree hash: d24040b39f5180fba3d77746c14c6d43aa7e1919
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Related Issue(s)
Fixes gitpod-io/gitpod-microsoft-aks-guide#6
How to test
Create Azure storage account and create a secret:
Now update the config:
Release Notes
Documentation