Remove team when sole owner and remove projects

[laushinka]

Description

1. Removes user projects
2. Removes teams when user is sole owner of the teams
3. Removes projects of those sole-owned teams

Related Issue(s)

Fixes #6655

How to test

The testing is quite extensive.
Test 1:

1. Create a team
2. Add a member to that team
3. Add a project to that team
4. Set one team as owner, one as member
5. Have the owner delete their user account. Expectation: team and project should be deleted.

Test 2:

1. Redo steps 1-4 above.
2. Have the member delete their user account. Expectation: team and project should not be deleted.

Test 3:

1. Redo steps 1-3 above.
2. Set both members as owners.
3. Have one owner delete their user account. Expectation: team and project should not be deleted.

Test 4:

1. Add project to the user.
2. Delete the user. Expectation: project should be deleted, i.e. that project is available to be added again.

Release Notes

When a user deletes their account, own projects will be deleted and made available to be added again.
When the user is the sole owner of a team, that team and its projects will be deleted and made available to be added again.

Documentation

[jankeromnes]

Super cool, many thanks! Taking a look now 👀

[jankeromnes]

Thanks for implementing this clean-up! I think this is going to be really helpful. ✨

I've left a few thoughts and comments in-line. Please have a look, and decide whether to accept or decline my suggestions. 🙂

Also, I tried running through your test protocol, but faced a few problems:

Test 1:

1. Create a team

I logged in with GitHub and created a new team, and copied the invite URL.

2. Add a member to that team

I copied the invite URL, then opened a private browser tab, logged in with GitLab (created a new Gitpod account, which I needed to unblock), then visited the invite URL to join as a member.

3. Add a project to that team

I (perhaps sneakily) decided to add the projects as the new GitLab member (and not the original GitHub team owner). Doing this, I ran into #6743 (probably unrelated to this PR, but maybe this is where things went wrong)

4. Set one team as owner, one as member

This was already the case (the original GitHub team creator was already the owner, and the new GitLab invited member was already a member) so no action needed.

5. Have the owner delete their user account. Expectation: team and project should be deleted.

When I deleted the original GitHub user account, I found in my private window (where the GitLab member was still logged in) that the team still existed, now without any owner, and that also the projects still existed:

Maybe I did something wrong? Or maybe it's the problem I noticed in the SQL query (see below)

Happy to discuss and/or clarify and/or help! 😇

[laushinka]

@jankeromnes Thank you for all the insights and for taking the time! I will go through them one by one 🤗

[laushinka]

/hold

[codecov]

Codecov Report

Merging #6721 (4f49b77) into main (158acc4) will decrease coverage by 1.72%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #6721      +/-   ##
========================================
- Coverage   7.89%   6.16%   -1.73%     
========================================
  Files         14      12       -2     
  Lines       1254    1086     -168     
========================================
- Hits          99      67      -32     
+ Misses      1152    1018     -134     
+ Partials       3       1       -2     

Flag	Coverage Δ
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
installer-raw-app	6.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158acc4...4f49b77. Read the comment docs.

[laushinka]

@jankeromnes I've applied the changes and have tested different cases manually as well, including the one you mentioned above. Ready for another review 🙏🏽

[laushinka]

/unhold

[jankeromnes]

Many thanks Laurie! 🙏

Re-flagging myself for review so that I don't forget about this(!)

[jankeromnes]

Perfection! 🎯 ✨ Works as advertised!

Many thanks for teaching Teams & Projects to clean up after them 🧹 🙏

[roboquat]

LGTM label has been added.

Git tree hash: 23629167ff47fd2535253cd2a7b2e8589de0d7c4

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #6655

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/gitpod-db/OWNERS [jankeromnes]
• components/server/OWNERS [jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment