[ws-scheduler] Set supervisor ref for ghosts #6718
Conversation
roboquat
added
release-note-none
team: workspace
| @@ -291,7 +292,8 @@ func (wspd *WorkspaceManagerPrescaleDriver) startGhostWorkspaces(ctx context.Con | |||
| }, | |||
| DeprecatedIdeImage: wspd.Config.IDEImage, | |||
| IdeImage: &api.IDEImage{ | |||
| WebRef: wspd.Config.IDEImage, | |||
| WebRef: wspd.Config.IDEImage, | |||
| SupervisorRef: wspd.Config.SupervisorImage, | |||
There was a problem hiding this comment.
please add the corresponding entry in the installer
corneliusludmann
force-pushed
the
clu/supervisor-image-ghosts
branch
from
ad9356f to
ec159aa
Compare
Codecov Report
@@ Coverage Diff @@
## main #6718 +/- ##
==========================================
- Coverage 19.04% 6.16% -12.88%
==========================================
Files 2 12 +10
Lines 168 1086 +918
==========================================
+ Hits 32 67 +35
- Misses 134 1018 +884
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
LGTM label has been added. Git tree hash: 51da10b824ec85ca56c2ea8bf756241d77a76908
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6512 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
deployed: workspace
Description
This PR set the supervisor ref in the StartWorkspaceSpec for ghost workspaces.
This PR also updates the IDE image of the ghost workspaces to code stable instead of Theia.
How to test
Make sure that ghost workspaces start. You could also decode the imageSpec annotation.
Issues
Also part of #6512
Release Notes