-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Show loading indicator when switching git providers to add a new project #6711
Conversation
/werft run 👍 started the job as gitpod-build-jx-switch-load.1 |
There was already a loading state implemented, I just reactivated it when switching providers: Could potentially be made prettier though. 😇 @laushinka @gtsiolis any thoughts? ✨ |
I can't authorize GitHub in this preview env but when switching to GitLab I can see the loading page 🎉 |
Approving but holding off on the lgtm until @gtsiolis takes a look. /approve |
LGTM label has been added. Git tree hash: ebe6527ea1084586472c11272d250f63e177b76b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laushinka Associated issue: #6654 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh oops I saw the banner that it still needs my review even after approving, so I did that, turns out it then adds the lgtm label 😅 Sorry if @gtsiolis still wanted to take a look! |
That's perfect, many thanks for the review @laushinka! 🙏 😁 I also flagged @gtsiolis in case there is an opportunity to improve the design of the loading indicator, but we can also do that as a follow-up / later on. The most important thing was to use the loading indicator appropriately, which fixes the issue. ✅ |
Thanks @jankeromnes @laushinka! 🏓 FWIW, just tried this in staging and this looks like a great MVC (minimum viable change) iteration. ➿
|
Description
Show loading indicator when switching git providers to add a new project
Related Issue(s)
Fixes #6654
How to test
The switch should show the loading indicator while loading (and not the previous list of repos from the old provider)
Release Notes
Documentation
/uncc