-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager-bridge] Support forced cluster dereg #6682
Conversation
/approve no-issue |
/lgtm |
LGTM label has been added. Git tree hash: cc1fc47b4fd6f3698a4cf56f2764cbf94e4dee5d
|
/werft run 👍 started the job as gitpod-build-cw-cluster-force-dereg.1 |
Codecov Report
@@ Coverage Diff @@
## main #6682 +/- ##
========================================
- Coverage 7.89% 6.16% -1.73%
========================================
Files 14 12 -2
Lines 1254 1086 -168
========================================
- Hits 99 67 -32
+ Misses 1152 1018 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
👍 for the PR. We just need to be aware that leaving dangling workspaces around currently breaks UX for people that started those (bc they might run into an unresolvable "max parallel workspaces" situation). We had this incident end of last week with a temporary So fine with merging this as long as we:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , but keep #6682 (comment) in mind.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel, geropl Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds support for forced workspace cluster deregistration.
When de-registering a cluster, ws-manager-bridge checks if there are still any workspaces which belong to this cluster and are marked as running. If we removed the cluster in this case, those instances would never again receive a status update - also the reconciliation in ws-manager-bridge would no longer act on those workspaces (the cluster is gone after all, what should we reconcile with).
With the newly added
--force
flag on gpctl, we can override this safety mechanism in exceptional cases, e.g. when introducing new workspace cluster types.How to test
--force
, but should work with it.Release Notes