Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Add supervisor ref to IDEImage #6637

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

corneliusludmann
Copy link
Contributor

Description

This PR adds supervisor_ref to WorkspaceStatus in the ws-manager that allows to set the supervisor image to use for a workspace start. It is meant to replace the supervisor as a static layer in a next step.

Related Issue(s)

step for #6512.

How to test

Release Notes

NONE

@roboquat roboquat added release-note-none team: workspace Issue belongs to the Workspace team size/XXL labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #6637 (b6f219e) into main (64f4da8) will decrease coverage by 27.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6637       +/-   ##
==========================================
- Coverage   33.29%   6.00%   -27.29%     
==========================================
  Files          48      12       -36     
  Lines        8678    1116     -7562     
==========================================
- Hits         2889      67     -2822     
+ Misses       5551    1048     -4503     
+ Partials      238       1      -237     
Flag Coverage Δ
components-blobserve-app ?
components-blobserve-lib ?
components-image-builder-mk3-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-registry-facade-api-go-lib ?
components-registry-facade-app ?
components-registry-facade-lib ?
components-ws-manager-app ?
components-ws-proxy-app ?
components-ws-proxy-lib ?
installer-raw-app 6.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go
components/ws-manager/pkg/manager/status.go
...ents/image-builder-mk3/pkg/orchestrator/monitor.go
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go
...omponents/registry-facade/pkg/registry/imagecfg.go
components/image-builder/pkg/resolve/resolve.go
components/ws-proxy/pkg/proxy/infoprovider.go
components/blobserve/pkg/blobserve/blobserve.go
components/registry-facade/pkg/registry/blob.go
...omponents/registry-facade/pkg/registry/registry.go
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f4da8...b6f219e. Read the comment docs.

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50d77edbbfaadc24df1bcf4fb85824008245558d

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6512

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 6509092 into main Nov 11, 2021
@roboquat roboquat deleted the clu/supervisor-ref-ideimage branch November 11, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants