Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registry-facade] Add supervisor ref to ImageSpec #6628

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

corneliusludmann
Copy link
Contributor

Description

This PR adds supervisor_ref to ImageSpec in the registry-facade that allows to set the supervisor image to use for a workspace start. It is meant to replace the supervisor as a static layer in a next step.

Related Issue(s)

It's one step for #6512.

How to test

Release Notes

NONE

@roboquat roboquat added release-note-none team: workspace Issue belongs to the Workspace team size/L labels Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #6628 (2ae7f1f) into main (d2e9f27) will increase coverage by 30.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #6628       +/-   ##
==========================================
+ Coverage   7.71%   38.15%   +30.44%     
==========================================
  Files         14       37       +23     
  Lines       1284     6633     +5349     
==========================================
+ Hits          99     2531     +2432     
- Misses      1182     3903     +2721     
- Partials       3      199      +196     
Flag Coverage Δ
components-image-builder-mk3-app 35.03% <ø> (?)
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 39.50% <ø> (?)
components-ws-proxy-app 69.80% <ø> (?)
components-ws-proxy-lib 69.80% <ø> (?)
installer-raw-app 6.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/ws-proxy/pkg/proxy/proxy.go 30.35% <0.00%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/monitor.go 24.90% <0.00%> (ø)
components/ws-proxy/pkg/proxy/pass.go 75.60% <0.00%> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go 39.58% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.11% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 74.81% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e9f27...2ae7f1f. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b1ffce556185dfe673ce50b84eb285e31050582

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6512

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit fa8abe5 into main Nov 10, 2021
@roboquat roboquat deleted the clu/supervisor-ref-imagespec branch November 10, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants