-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: create a configmap with a simplified installation manifest #6591
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6591 +/- ##
========================================
- Coverage 8.17% 6.16% -2.01%
========================================
Files 14 12 -2
Lines 1211 1086 -125
========================================
- Hits 99 67 -32
+ Misses 1109 1018 -91
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
84cd99d
to
70ad206
Compare
70ad206
to
7225018
Compare
7225018
to
9edcb76
Compare
5303290
to
b0c9858
Compare
This can be used to uninstall the application
b0c9858
to
cb201bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"APIService", | ||
} | ||
|
||
type RuntimeObject struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future reference: we need to reign this back in; not export this in the future. Having our own version of what's essentially runtime.Object
doesn't bode well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed. I don't want this used for anything else
LGTM label has been added. Git tree hash: 2661f7e774ea83841236d2d0ea1e0cc5578251f2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6290 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Uninstallation can be invoked by
kubectl get configmaps gitpod-app -o jsonpath='{.data.app\.yaml}' | kubectl delete -f -
This also tidies up the sort function - it's gotten a bit bloated so it's doing about 3 different things. This separates out each part into individual parts (SOLID FTW)
Have also renamed the
sorter.go
file todisplay.go
as it's not just sorting in there now, which might get confusing to new eyesRelated Issue(s)
Fixes #6290
How to test
Deploy a version of the app, uninstall using the above command
Release Notes
Documentation