Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpctl] Support multiple container for debug logs #6542

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

csweichel
Copy link
Contributor

Description

This PR makes gpctl debug log support multiple containers so that it works e.g. for ws-daemon.

How to test

gpctl debug log ws-dameon

Release Notes

`gpctl debug log` supports multiple containers

@csweichel
Copy link
Contributor Author

/approve no-issue

@roboquat roboquat added team: workspace Issue belongs to the Workspace team approved size/M labels Nov 3, 2021
dev/gpctl/cmd/debug-log.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #6542 (c28b28f) into main (5934558) will increase coverage by 0.51%.
The diff coverage is n/a.

❗ Current head c28b28f differs from pull request most recent head 31dc563. Consider uploading reports for the commit 31dc563 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6542      +/-   ##
==========================================
+ Coverage   36.41%   36.92%   +0.51%     
==========================================
  Files          21       19       -2     
  Lines        4688     4520     -168     
==========================================
- Hits         1707     1669      -38     
+ Misses       2847     2716     -131     
- Partials      134      135       +1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 36.92% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/config/gitpod-config.go 76.78% <0.00%> (-2.68%) ⬇️
components/supervisor/pkg/ports/ports.go 60.75% <0.00%> (-0.52%) ⬇️
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5934558...31dc563. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Nov 4, 2021

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Nov 4, 2021

LGTM label has been added.

Git tree hash: d004c31dac0c54d2690de3cf60df172c69928b23

@roboquat
Copy link
Contributor

roboquat commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit eb4ab9d into main Nov 4, 2021
@roboquat roboquat deleted the cw/gpctl-logs branch November 4, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants