Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle private GitHub repos on Config Page #6451

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Oct 29, 2021

Fixes #6168

To be more specific what this PR resolves and how to verify:

  1. ensure you have just user:email permissions for GitHub on https://at-config-private-repo-6168.staging.gitpod-dev.com/integrations
  2. go to https://at-config-private-repo-6168.staging.gitpod-dev.com/new and import a private repo from your account as a project
  3. on the configuration page you should now see the Authorize button
  4. do authorize and grant repo permissions
  5. the project configuration fetch should be repeated automatically

2021-10-29 14 15 17

Handle private GitHub repos on Config Page

@AlexTugarev AlexTugarev changed the title At/config-private-repo-6168 Handle private GitHub repos on Config Page Oct 29, 2021
@AlexTugarev AlexTugarev marked this pull request as ready for review October 29, 2021 10:30
@jldec
Copy link
Contributor

jldec commented Oct 29, 2021

@AlexTugarev I tried this on https://at-config-private-repo-6168.staging.gitpod-dev.com/
I installed my personal github app there to test the flow with a private github repo.

I noticed 2 things:

  1. this PR is based on a fairly old commit on main - it would be good to rebase/merge the recent commits e.g. to include the changes to the "New Workspace" button.

  2. I'm seeing the new no-access notice in the pane on the left 👍 , but I still get unhandled errors in the console, both before and after clicking the "Authorize Provider" button, and then the page is stuck with no way to continue.

Uncaught (in promise) Error: Request guessProjectConfiguration failed with message: NotFoundError
Uncaught (in promise) Error: Request fetchProjectRepositoryConfiguration failed with message: NotFoundError

@AlexTugarev AlexTugarev force-pushed the at/config-private-repo-6168 branch from 32a4f8c to 9bbb0f4 Compare October 29, 2021 12:16
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me now, thank you @AlexTugarev !

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 83c1388b6df44c338b1b3b272eeaf978e209346b

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #6168

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit af780e9 into main Oct 29, 2021
@roboquat roboquat deleted the at/config-private-repo-6168 branch October 29, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Project flow fails detection on private repos if oauth is fresh
3 participants