Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager]: change affinities to match the installer values #6428

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

Change affinities to match the installer values

Related Issue(s)

Fixes #6404

How to test

Release Notes

Change affinities to match the installer values

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team labels Oct 27, 2021
@roboquat roboquat requested a review from princerachit October 27, 2021 19:09
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #6428 (22d194b) into main (5f84be7) will increase coverage by 20.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6428       +/-   ##
===========================================
+ Coverage   19.04%   39.55%   +20.50%     
===========================================
  Files           2       13       +11     
  Lines         168     3790     +3622     
===========================================
+ Hits           32     1499     +1467     
- Misses        134     2168     +2034     
- Partials        2      123      +121     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 39.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go 79.84% <100.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-manager/pkg/clock/clock.go 68.62% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 25.10% <0.00%> (ø)
components/ws-manager/pkg/manager/manager_ee.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.11% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/monitor.go 8.98% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f84be7...22d194b. Read the comment docs.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e6bb76d601fc2fbdf5fcaceed92b5ad67d2d3c0

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: princerachit

Associated issue: #6404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 61c8f54 into main Oct 28, 2021
@roboquat roboquat deleted the sje/affinity-6404 branch October 28, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid value used for ws-manager node affinity
3 participants