-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspaces] Support workspace-wide network namespace #6409
Conversation
/approve |
/approve no-issue |
/lgtm |
LGTM label has been added. Git tree hash: 8e386fd65d58aae051999405afdc9e81001b6622
|
/approve protocol and server changes LGTM |
9b79e13
to
3dcfb86
Compare
/approve |
/lgtm |
Codecov Report
@@ Coverage Diff @@
## main #6409 +/- ##
==========================================
- Coverage 40.03% 38.38% -1.65%
==========================================
Files 55 18 -37
Lines 10721 4343 -6378
==========================================
- Hits 4292 1667 -2625
+ Misses 6097 2544 -3553
+ Partials 332 132 -200
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@csweichel: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: d586c0ec9c91edb9452a6ad955049d79a431c0ec
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, corneliusludmann, csweichel, JanKoehnlein Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR introduces an "experimental network" mode for workspaces whereby the entire workspace is wrapped in a network namespace. This enables a seamless tailscale experience in a Gitpod workspace, at the cost of networking performance.
Once we have
seccomp_addfd
available in prod we can make this GA and remove the config flag.How to test
Open https://cw-wskit-netns.staging.gitpod-dev.com/#https://github.com/gitpod-io/template-tailscale/tree/cw/demo
Release Notes
Documentation