-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Add autofocus to some modal #6408
Conversation
@gtsiolis Do I split PR ? or just keep this ? |
Thanks @iQQBot! Could you split this as you suggested in #6408 (comment) if that's not too much to ask? 🙈 I'd love to keep these two fixes separate and loop in @laushinka for another pair of eyes in fixing #6383 since she was also involved in a closely related PR in #6058. 👀 /werft run 👍 started the job as gitpod-build-pd-auto-focus-fork.0 |
/werft run 👍 started the job as gitpod-build-pd-auto-focus-fork.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flawless! Thanks @iQQBot! Changes look great. 🔮
@@ -37,7 +37,7 @@ export default function () { | |||
<div className="border rounded-xl p-6 border-gray-100 dark:border-gray-800"> | |||
<h3 className="text-center text-xl mb-6">What's your team's name?</h3> | |||
<h4>Team Name</h4> | |||
<input className={`w-full${!!creationError ? ' error' : ''}`} type="text" onChange={event => name = event.target.value} /> | |||
<input autoFocus className={`w-full${!!creationError ? ' error' : ''}`} type="text" onChange={event => name = event.target.value} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: YES!
@@ -175,7 +175,7 @@ export function WorkspaceEntry({ desc, model, isAdmin, stopWorkspace }: Props) { | |||
{errorMessage} | |||
</div> | |||
: null} | |||
<input className="w-full truncate" type="text" defaultValue={workspaceDescription} ref={renameInputRef} /> | |||
<input autoFocus className="w-full truncate" type="text" defaultValue={workspaceDescription} ref={renameInputRef} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: This feels good!
LGTM label has been added. Git tree hash: 0923ed49fb4137479d3f6930ec7ec37183034f0c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtsiolis Associated issue: #6371 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add autofocus when renaming a workspace, deleting account, deleting team, add environment, add team
Related Issue(s)
Fixes #6371
How to test
Release Notes
Documentation