-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ide] Add JetBrains IDE images #6367
Conversation
b4ddbf9
to
74d451c
Compare
@@ -18,6 +18,20 @@ | |||
{{ template "gitpod.comp.imageRepo" . }}:{{- $comp.insidersVersion | default (include "gitpod.comp.version" .) -}} | |||
{{- end -}} | |||
|
|||
{{- define "ide-images-aliases"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for simplifying, now it is readable!
/werft run 👍 started the job as gitpod-build-clu-add-jetbrains-images.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
smoke tested that VS Code stable and insiders still picked properly
LGTM label has been added. Git tree hash: de6f4086559f7b052411f70427bfc96cc2fee865
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov Associated issue: #6270 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR has the parts of the umbrella PR #6270 that adds the JetBrains IDE images
See #6270 (comment) for more info.
Release Notes