Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ide] Add JetBrains IDE images #6367

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[ide] Add JetBrains IDE images #6367

merged 1 commit into from
Oct 27, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Oct 22, 2021

Description

This PR has the parts of the umbrella PR #6270 that adds the JetBrains IDE images

See #6270 (comment) for more info.

Release Notes

NONE

@@ -18,6 +18,20 @@
{{ template "gitpod.comp.imageRepo" . }}:{{- $comp.insidersVersion | default (include "gitpod.comp.version" .) -}}
{{- end -}}

{{- define "ide-images-aliases"}}
Copy link
Member

@akosyakov akosyakov Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for simplifying, now it is readable!

@akosyakov
Copy link
Member

akosyakov commented Oct 27, 2021

/werft run

👍 started the job as gitpod-build-clu-add-jetbrains-images.2

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

smoke tested that VS Code stable and insiders still picked properly

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: de6f4086559f7b052411f70427bfc96cc2fee865

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue: #6270

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0f36285 into main Oct 27, 2021
@roboquat roboquat deleted the clu/add-jetbrains-images branch October 27, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants