Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] Add desktop IDE backend support #6365

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Oct 22, 2021

Description

This PR has the parts of the umbrella PR #6270 that change supervisor backend to support desktop IDE images.

See #6270 (comment) for more info.

Release Notes

NONE

/werft with-clean-slate-deployment
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #6365 (40177c6) into main (16e51a3) will increase coverage by 15.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6365       +/-   ##
===========================================
+ Coverage   19.04%   34.76%   +15.72%     
===========================================
  Files           2        4        +2     
  Lines         168      975      +807     
===========================================
+ Hits           32      339      +307     
- Misses        134      596      +462     
- Partials        2       40       +38     
Flag Coverage Δ
components-image-builder-mk3-app 34.76% <ø> (?)
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
...image-builder-mk3/pkg/orchestrator/orchestrator.go 39.16% <0.00%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/monitor.go 24.90% <0.00%> (ø)
components/image-builder/pkg/resolve/resolve.go 32.65% <0.00%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/metrics.go 48.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e51a3...40177c6. Read the comment docs.

@csweichel
Copy link
Contributor

didn't test, but API changes lgtm

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35b04ae58980ab51633425f85440d497de944bec

@princerachit
Copy link
Contributor

@corneliusludmann are you planning to write test for this? I am not sure how I can test/verify these changes.

@corneliusludmann
Copy link
Contributor Author

corneliusludmann commented Oct 25, 2021

@princerachit Currently, this change can be tested by using the “umbrella PR” #6270 (see also discussion in #6270 (comment)). This PR has all pieces (including the commit of this PR) that are needed to run this.

@akosyakov
Copy link
Member

akosyakov commented Oct 27, 2021

/werft run

👍 started the job as gitpod-build-clu-desktop-ide-supervisor-backend.1

@akosyakov
Copy link
Member

/lgtm

tested changed supervisor endpoints and web IDE restart

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, csweichel, princerachit

Associated issue: #6270

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 19dcaa4 into main Oct 27, 2021
@roboquat roboquat deleted the clu/desktop-ide-supervisor-backend branch October 27, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants