-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supervisor] Add desktop IDE backend support #6365
Conversation
/werft with-clean-slate-deployment
Codecov Report
@@ Coverage Diff @@
## main #6365 +/- ##
===========================================
+ Coverage 19.04% 34.76% +15.72%
===========================================
Files 2 4 +2
Lines 168 975 +807
===========================================
+ Hits 32 339 +307
- Misses 134 596 +462
- Partials 2 40 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
didn't test, but API changes lgtm /lgtm |
LGTM label has been added. Git tree hash: 35b04ae58980ab51633425f85440d497de944bec
|
@corneliusludmann are you planning to write test for this? I am not sure how I can test/verify these changes. |
@princerachit Currently, this change can be tested by using the “umbrella PR” #6270 (see also discussion in #6270 (comment)). This PR has all pieces (including the commit of this PR) that are needed to run this. |
/werft run 👍 started the job as gitpod-build-clu-desktop-ide-supervisor-backend.1 |
/lgtm tested changed supervisor endpoints and web IDE restart |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, csweichel, princerachit Associated issue: #6270 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR has the parts of the umbrella PR #6270 that change
supervisor
backend to support desktop IDE images.See #6270 (comment) for more info.
Release Notes