-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to install meta components to GKE with InCluster dependencies #6355
Conversation
6748aea
to
29f88a6
Compare
9d9a1d3
to
56fd8c1
Compare
f566f8c
to
39851b0
Compare
56fd8c1
to
4be9f53
Compare
39851b0
to
e34326c
Compare
4be9f53
to
680b09c
Compare
e34326c
to
d3673d0
Compare
2003367
to
a4cb89f
Compare
d3673d0
to
6c8b206
Compare
a4cb89f
to
f12552c
Compare
6c8b206
to
48888c7
Compare
9a66833
to
46ee3c1
Compare
48888c7
to
dd26d45
Compare
fb04a3d
to
4d8a0fa
Compare
4d8a0fa
to
84dd5c2
Compare
@corneliusludmann could you review openvsx proxy changes please? 🙏 |
6ce0431
to
fb92850
Compare
This now installs the meta components to a cluster using an InCluster database and registry
fb92850
to
0d9c194
Compare
{Name: "GITPOD_INSTALLATION_LONGNAME", Value: cfg.Domain}, // todo(sje): figure out these values | ||
{Name: "GITPOD_INSTALLATION_SHORTNAME", Value: cfg.Domain}, // todo(sje): figure out these values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which component actually uses those? Is it worth making them available to all components, considering that once they're present they'll be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its seems to be used by quite a lot of the meta components as it's pulled in from a TS file. There's a lot of references to installationShortname
in the source code as well
/approve Code-wise, the change to the OpenVSX proxy looks good so far. Didn't test installing the stuff, though. |
/lgtm |
LGTM label has been added. Git tree hash: 7278ccf1dc5b8bad034e3b74168ca0ae1cd7dbec
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusludmann, csweichel Associated issue: #6323 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This follows on from #6323, applying the fixes to the meta components. This now installs a complete self-hosted instance in GKE with InCluster dependencies
Related Issue(s)
Fixes #6276
Fixes #6122
How to test
As per #6323
Release Notes
Documentation