Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to install meta components to GKE with InCluster dependencies #6355

Merged
merged 5 commits into from
Nov 2, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Oct 22, 2021

Description

This follows on from #6323, applying the fixes to the meta components. This now installs a complete self-hosted instance in GKE with InCluster dependencies

  • add OpenVSX component
  • trigger a DB migration job - as we're not using Helm, have used the DB waiter init container which seems to emulate the post-install/upgrade hook well
  • add custom server annotations to each component as per [Installer]: add the number of replicas required for a deployment in the config #6357. The currently self-hosted GKE guide uses external-dns to update CloudDNS, which requires the addition of annotations to the proxy service. I imagine that there will be many users who want their own annotations on services, this seems like a good first step to that - I would advocate that this should just be a passthru as we'll never keep up with the community's requirements otherwise.

Related Issue(s)

Fixes #6276
Fixes #6122

How to test

As per #6323

Release Notes

Successfully install the meta components to a cluster and perform a DB migration

Documentation

@mrsimonemms mrsimonemms changed the base branch from main to sje/installer-gke October 22, 2021 09:34
@roboquat roboquat added size/XS and removed size/XXL labels Oct 22, 2021
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from 6748aea to 29f88a6 Compare October 22, 2021 14:19
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from f566f8c to 39851b0 Compare October 25, 2021 08:45
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from 39851b0 to e34326c Compare October 25, 2021 11:13
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from e34326c to d3673d0 Compare October 25, 2021 13:49
@mrsimonemms mrsimonemms force-pushed the sje/installer-gke branch 2 times, most recently from 2003367 to a4cb89f Compare October 26, 2021 07:36
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from d3673d0 to 6c8b206 Compare October 26, 2021 07:42
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from 6c8b206 to 48888c7 Compare October 26, 2021 08:21
@mrsimonemms mrsimonemms force-pushed the sje/installer-gke branch 2 times, most recently from 9a66833 to 46ee3c1 Compare October 26, 2021 08:51
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from 48888c7 to dd26d45 Compare October 26, 2021 08:57
@mrsimonemms mrsimonemms linked an issue Oct 26, 2021 that may be closed by this pull request
@mrsimonemms mrsimonemms marked this pull request as ready for review October 26, 2021 11:29
@mrsimonemms mrsimonemms requested a review from csweichel October 26, 2021 11:29
@mrsimonemms mrsimonemms changed the base branch from sje/installer-gke to main October 26, 2021 11:30
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from fb04a3d to 4d8a0fa Compare October 26, 2021 16:06
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from 4d8a0fa to 84dd5c2 Compare October 27, 2021 10:57
@akosyakov
Copy link
Member

akosyakov commented Oct 28, 2021

@corneliusludmann could you review openvsx proxy changes please? 🙏

@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch 2 times, most recently from 6ce0431 to fb92850 Compare October 28, 2021 12:38
@mrsimonemms mrsimonemms force-pushed the sje/installer-meta-fixes-gke branch from fb92850 to 0d9c194 Compare November 1, 2021 09:47
Comment on lines +64 to +65
{Name: "GITPOD_INSTALLATION_LONGNAME", Value: cfg.Domain}, // todo(sje): figure out these values
{Name: "GITPOD_INSTALLATION_SHORTNAME", Value: cfg.Domain}, // todo(sje): figure out these values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which component actually uses those? Is it worth making them available to all components, considering that once they're present they'll be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its seems to be used by quite a lot of the meta components as it's pulled in from a TS file. There's a lot of references to installationShortname in the source code as well

@corneliusludmann
Copy link
Contributor

/approve

Code-wise, the change to the OpenVSX proxy looks good so far. Didn't test installing the stuff, though.

@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

LGTM label has been added.

Git tree hash: 7278ccf1dc5b8bad034e3b74168ca0ae1cd7dbec

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann, csweichel

Associated issue: #6323

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 8884ea2 into main Nov 2, 2021
@roboquat roboquat deleted the sje/installer-meta-fixes-gke branch November 2, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: successfully deploy to GKE with InCluster configuration [Installer]: handle DB migrations
5 participants