-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer] Add config validation #6265
Conversation
4391910
to
1cb1dc6
Compare
I've decided to keep validating the database/object store until after I've got these connecting to GCP, which is my next job |
/assign @csweichel |
1cb1dc6
to
f43c35b
Compare
I am seeing an error while running the command:
|
@princerachit Replace |
/lgtm |
LGTM label has been added. Git tree hash: 87815dad1231ba9e4aa8976158f614423c626487
|
f43c35b
to
cd17c37
Compare
This includes some refactoring of the render command as the config validation and render commands share some of the same principles.
cd17c37
to
35380f0
Compare
Codecov Report
@@ Coverage Diff @@
## main #6265 +/- ##
========================================
- Coverage 8.21% 6.08% -2.14%
========================================
Files 12 10 -2
Lines 1022 854 -168
========================================
- Hits 84 52 -32
+ Misses 934 800 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
LGTM label has been added. Git tree hash: c040def9fb4b18ed23989477a4e4e336f4b62d57
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, princerachit Associated issue: #6102 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Validate the given configuration
Related Issue(s)
Fixes #6102
How to test
go run . validate config --config /path/to/config.yaml
This also can be done with
go run . render --config /path/to/config.yaml
Release Notes
Documentation