-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace /workspaces → /projects as default landing page for both users and teams #6048
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -395,7 +395,7 @@ export async function deployToDev(deploymentConfig: DeploymentConfig, workspaceF | |
werft.fail('deploy', err); | ||
} finally { | ||
// produce the result independently of Helm succeding, so that in case Helm fails we still have the URL. | ||
exec(`werft log result -d "dev installation" -c github-check-preview-env url ${url}/workspaces/`); | ||
exec(`werft log result -d "dev installation" -c github-check-preview-env url ${url}/projects`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Probably going with |
||
} | ||
|
||
werft.log(`observability`, "Running observability static checks.") | ||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -112,17 +112,24 @@ export default function () { | |||
{projects.filter(filter).sort(hasNewerPrebuild).map(p => (<div key={`project-${p.id}`} className="h-52"> | ||||
<div className="h-42 border border-gray-100 dark:border-gray-800 rounded-t-xl"> | ||||
<div className="h-32 p-6"> | ||||
<div className="flex text-xl font-semibold text-gray-700 dark:text-gray-200 font-medium"> | ||||
<div className="flex text-gray-700 dark:text-gray-200 font-medium"> | ||||
<Link to={`/${teamOrUserSlug}/${p.name}`}> | ||||
{p.name} | ||||
<span className="text-xl font-semibold">{p.name}</span> | ||||
</Link> | ||||
<span className="flex-grow" /> | ||||
<div className="justify-end"> | ||||
<ContextMenu menuEntries={[{ | ||||
title: "Remove Project", | ||||
customFontStyle: 'text-red-600 dark:text-red-400 hover:text-red-800 dark:hover:text-red-300', | ||||
onClick: () => onRemoveProject(p) | ||||
}]} /> | ||||
<ContextMenu menuEntries={[ | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: This is out of the scope of these changes but do you think it'd be easy to add a hover state on the more action button as seen everywhere else? Adding
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! Pushed a new drive-by commit to fix this. 🚀 EDIT: In #6185, that is. |
||||
{ | ||||
title: "New Workspace", | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: YES! |
||||
href: `/#${p.cloneUrl}`, | ||||
separator: true, | ||||
}, | ||||
{ | ||||
title: "Remove Project", | ||||
customFontStyle: 'text-red-600 dark:text-red-400 hover:text-red-800 dark:hover:text-red-300', | ||||
onClick: () => onRemoveProject(p) | ||||
}, | ||||
]} /> | ||||
</div> | ||||
</div> | ||||
<a href={p.cloneUrl.replace(/\.git$/, '')}> | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Nice one! 💯