-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Gracefully handle websocket connection disposal #6006
Conversation
This avoids Error("Connection got disposed") errors which gobble up to the frontend and block users.
@geropl What is the difference to previous version? |
@akosyakov The previous version removed this section entirely, thus we never fired |
/werft run 👍 started the job as gitpod-build-gpl-5042-conn-disposed-2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It makes sense. Too bad we overlooked the server part initially.
LGTM label has been added. Git tree hash: 930a29dc722e1f0704886cb3088c20b5c749b3ae
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, geropl Associated issue: #5042 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This avoids Error("Connection got disposed") errors which gobble up to the frontend and block users. Also, it makes the frontend's websocket connection more resilient in general: Instead of dropping calls, those are buffered and re-issued once the connection is reestablished.
Related Issue(s)
Fixes #5042.
How to test
Login to preview env
Start a workspace
View build logs
server
)Ensure closing websocket connections works
kubectl port-forward deployment/server 9500
curl -s localhost:9500/metrics | grep "gitpod_server_api_connections_closed_total "
and remember the numbercurl -s localhost:9500/metrics | grep "gitpod_server_api_connections_closed_total "
again and note how the count increasedRelease Notes