Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] Add index 'ind_dbsync' on d_b_code_sync_resource #6005

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[db] Add index 'ind_dbsync' on d_b_code_sync_resource #6005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions components/gitpod-db/src/typeorm/migration/1633334251143-IndexCodeSyncCreated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/**
* Copyright (c) 2021 Gitpod GmbH. All rights reserved.
* Licensed under the GNU Affero General Public License (AGPL).
* See License-AGPL.txt in the project root for license information.
*/

import {MigrationInterface, QueryRunner} from "typeorm";
import { indexExists } from "./helper/helper";

const INDEX_NAME = "ind_dbsync";
const TABLE_NAME = "d_b_code_sync_resource";

export class IndexCodeSyncCreated1633334251143 implements MigrationInterface {

public async up(queryRunner: QueryRunner): Promise<any> {
if (!(await indexExists(queryRunner, TABLE_NAME, INDEX_NAME))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, today I learned about this helper (which doesn't seem to be used anywhere):

gitpod/components/gitpod-db/src/typeorm/migration/helper/helper.ts

Lines 9 to 18 in af51739

export async function createIndexIfNotExist(queryRunner: QueryRunner, tableName: string, indexName: string, columns: string[]): Promise<void> {
if (columns.length === 0) {
throw new Error("createIndexIfNotExist: Columns must not be empty!");
}
if (!indexExists(queryRunner, tableName, indexName)) {
const columnsStr = columns.map(cn => `\`${cn}\``).join(", ");
await queryRunner.query(`CREATE INDEX ${indexName} ON ${tableName} (${columnsStr})`);
}
};

However, no action needed here (feel free to resolve).

await queryRunner.query(`CREATE INDEX ${INDEX_NAME} ON ${TABLE_NAME} (created)`);
}
}

public async down(queryRunner: QueryRunner): Promise<any> {
await queryRunner.query(`DROP INDEX ${INDEX_NAME} ON ${TABLE_NAME}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to remove the index again if rolling back? (I think we could also leave it in place without consequence.)

}

}