Laushinka/allow users to delete 5066 #5966

laushinka · 2021-09-30T16:48:28Z

Description

A new settings page for teams.
Allows team deletion on the settings page.
When a team is deleted, projects are also deleted.

Related Issue(s)

How to test

Release Notes

Teams get a dedicated settings page where for now deletion can be done.

JanKoehnlein · 2021-10-01T06:20:37Z

/werft run

👍 started the job as gitpod-build-laushinka-allow-users-to-delete-5066.29

laushinka · 2021-10-01T08:33:48Z

@gtsiolis @JanKoehnlein I just realized that members should be removed as well. I will push another commit and meanwhile hold the PR.

laushinka · 2021-10-01T08:34:15Z

/hold

gtsiolis · 2021-10-01T09:21:51Z

@laushinka let us know when this is ready for review!

laushinka · 2021-10-01T09:23:24Z

/unhold

laushinka · 2021-10-01T09:23:50Z

@laushinka let us know when this is ready for review!

@gtsiolis @JanKoehnlein Ready now. Just finished testing the member removal. Also just fyi I'm unable to log into Slack.

gtsiolis · 2021-10-01T09:59:31Z

Looking at this now! 👀

gtsiolis

Great to see this happening, @laushinka! 🧁

So much looking forward for being able to delete teams in staging and production. 🙌

Left some comments below! Let me know what you think.

components/dashboard/src/teams/TeamSettings.tsx

gtsiolis · 2021-10-01T10:11:39Z

components/dashboard/src/Menu.tsx

+                },
+                {
+                    title: 'Settings',
+                    link: `/t/${team.slug}/settings`,


issue(blocking): Although permissions are still not clear for team owners and members, it makes sense to allow only team owners to delete a team, right? Cross-posting WIP documentation from https://github.com/gitpod-io/website/pull/842 for visibility. 👀

suggestion: Since settings currently include only one action to delete a team, what do you think of hiding the settings tab for non-owners? Cc @svenefftinge because #5066 (comment) and relevant discussion (internal).

@gtsiolis You're right, this makes sense!

gtsiolis · 2021-10-01T10:13:50Z

components/dashboard/src/teams/TeamSettings.tsx

+        <PageWithSubMenu subMenu={settingsMenu} title='General' subtitle='Manage general team settings.'>
+            <h3>Delete Team</h3>
+            <p className="text-base text-gray-500 pb-4">Deleting this team will also remove all associated data with this team, including projects and workspaces. Deleted teams cannot be restored!</p>
+            <button className="danger secondary" onClick={() => setModal(true)}>Delete Account</button>


issue: This returns an error in console and so feedback to the user when they are have member permissions, not owner permission, which also lacks visual feedback for the user. Hiding the project settings page for members (non-owners) could resolve this issue. WDYT? ❓

gtsiolis · 2021-10-01T10:21:12Z

components/dashboard/src/teams/TeamSettings.tsx

+        <PageWithSubMenu subMenu={settingsMenu} title='General' subtitle='Manage general team settings.'>
+            <h3>Delete Team</h3>
+            <p className="text-base text-gray-500 pb-4">Deleting this team will also remove all associated data with this team, including projects and workspaces. Deleted teams cannot be restored!</p>
+            <button className="danger secondary" onClick={() => setModal(true)}>Delete Account</button>


issue: This removes the team entry in the team scope selector but 🅰️ does not actually remove the rest of the team members and 🅱️ the rest of the team previously added as members or owners can still access team page, add projects, open workspaces, and trigger prebuilds. Shall we redirect back to the personal account when a user tries to access resources for a deleted team?

This is still an issue. Minor and non-blocking. Added follow up #6016.

gtsiolis · 2021-10-01T10:21:55Z

components/dashboard/src/teams/TeamSettings.tsx

+        <PageWithSubMenu subMenu={settingsMenu} title='General' subtitle='Manage general team settings.'>
+            <h3>Delete Team</h3>
+            <p className="text-base text-gray-500 pb-4">Deleting this team will also remove all associated data with this team, including projects and workspaces. Deleted teams cannot be restored!</p>
+            <button className="danger secondary" onClick={() => setModal(true)}>Delete Account</button>


suggestion: When deleting a team a user is redirected back to /account. What do you think of redirecting back to the starting page of the user, /workspaces?

Yes, I was torn re where to redirect and was looking forward to your input. It can be a bit disorienting to delete a team and then suddenly seeing another settings page, so I agree with redirecting back to /workspaces.

laushinka · 2021-10-01T15:45:30Z

@gtsiolis It's ready for another review!

laushinka · 2021-10-03T21:05:44Z

/werft run

👍 started the job as gitpod-build-laushinka-allow-users-to-delete-5066.36

Fixes #5066

JanKoehnlein · 2021-10-04T11:12:10Z

/werft run

👍 started the job as gitpod-build-laushinka-allow-users-to-delete-5066.42

laushinka · 2021-10-04T13:09:03Z

/werft run

👍 started the job as gitpod-build-laushinka-allow-users-to-delete-5066.43

JanKoehnlein · 2021-10-04T14:20:33Z

/lgtm

roboquat · 2021-10-04T14:20:37Z

LGTM label has been added.

Git tree hash: 0da431ffac03389cf65df56ab5b1f9883826580b

roboquat · 2021-10-04T14:20:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #5066

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [JanKoehnlein]
~~components/gitpod-db/OWNERS~~ [JanKoehnlein]
~~components/gitpod-protocol/OWNERS~~ [JanKoehnlein]
~~components/server/OWNERS~~ [JanKoehnlein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gtsiolis · 2021-10-04T15:09:15Z

Thanks @laushinka @JanKoehnlein! 🏀

Just took another look at this and noticed the issue in #5966 (comment) is still present.

Added a follow-up issue in #6016 since this has been merged as this seems to be minor and an edge case, see #5966 (comment).

roboquat added release-note do-not-merge/work-in-progress labels Sep 30, 2021

roboquat requested review from AlexTugarev, gtsiolis, JanKoehnlein and svenefftinge September 30, 2021 16:48

laushinka removed request for gtsiolis, svenefftinge, JanKoehnlein and AlexTugarev September 30, 2021 16:48

roboquat added the size/L label Sep 30, 2021

laushinka force-pushed the laushinka/allow-users-to-delete-5066 branch from 6ecdb57 to b144324 Compare September 30, 2021 17:02

laushinka marked this pull request as ready for review September 30, 2021 17:04

roboquat removed the do-not-merge/work-in-progress label Sep 30, 2021

laushinka requested review from gtsiolis and JanKoehnlein September 30, 2021 17:06

roboquat added do-not-merge/release-note-label-needed release-note and removed release-note do-not-merge/release-note-label-needed labels Sep 30, 2021

roboquat added the do-not-merge/hold label Oct 1, 2021

roboquat removed the do-not-merge/hold label Oct 1, 2021

gtsiolis suggested changes Oct 1, 2021

View reviewed changes

roboquat assigned gtsiolis Oct 1, 2021

laushinka force-pushed the laushinka/allow-users-to-delete-5066 branch from 9e0c55b to c12fa27 Compare October 3, 2021 21:53

[dashboard] Team settings page

5737672

Fixes #5066

laushinka force-pushed the laushinka/allow-users-to-delete-5066 branch from db2a679 to 5737672 Compare October 3, 2021 23:14

gtsiolis self-requested a review October 4, 2021 08:11

roboquat assigned JanKoehnlein Oct 4, 2021

roboquat added the lgtm label Oct 4, 2021

roboquat added the approved label Oct 4, 2021

roboquat merged commit 6ff8888 into main Oct 4, 2021

roboquat deleted the laushinka/allow-users-to-delete-5066 branch October 4, 2021 14:20

gtsiolis mentioned this pull request Oct 4, 2021

Deleting a team does not remove member access to team pages and resources #6016

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Laushinka/allow users to delete 5066 #5966

Laushinka/allow users to delete 5066 #5966

laushinka commented Sep 30, 2021 •

edited

Loading

JanKoehnlein commented Oct 1, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Oct 1, 2021

laushinka commented Oct 1, 2021

gtsiolis commented Oct 1, 2021

laushinka commented Oct 1, 2021

laushinka commented Oct 1, 2021 •

edited

Loading

gtsiolis commented Oct 1, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

gtsiolis Oct 1, 2021

laushinka Oct 1, 2021

gtsiolis Oct 1, 2021

gtsiolis Oct 1, 2021

gtsiolis Oct 4, 2021

gtsiolis Oct 1, 2021

laushinka Oct 1, 2021

laushinka commented Oct 1, 2021

laushinka commented Oct 3, 2021 •

edited by werft-gitpod-dev-com bot

Loading

JanKoehnlein commented Oct 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Oct 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

JanKoehnlein commented Oct 4, 2021

roboquat commented Oct 4, 2021

roboquat commented Oct 4, 2021

gtsiolis commented Oct 4, 2021 •

edited

Loading

Laushinka/allow users to delete 5066 #5966

Laushinka/allow users to delete 5066 #5966

Conversation

laushinka commented Sep 30, 2021 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

JanKoehnlein commented Oct 1, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Oct 1, 2021

laushinka commented Oct 1, 2021

gtsiolis commented Oct 1, 2021

laushinka commented Oct 1, 2021

laushinka commented Oct 1, 2021 • edited Loading

gtsiolis commented Oct 1, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

gtsiolis Oct 1, 2021

Choose a reason for hiding this comment

laushinka Oct 1, 2021

Choose a reason for hiding this comment

gtsiolis Oct 1, 2021

Choose a reason for hiding this comment

gtsiolis Oct 1, 2021

Choose a reason for hiding this comment

gtsiolis Oct 4, 2021

Choose a reason for hiding this comment

gtsiolis Oct 1, 2021

Choose a reason for hiding this comment

laushinka Oct 1, 2021

Choose a reason for hiding this comment

laushinka commented Oct 1, 2021

laushinka commented Oct 3, 2021 • edited by werft-gitpod-dev-com bot Loading

JanKoehnlein commented Oct 4, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Oct 4, 2021 • edited by werft-gitpod-dev-com bot Loading

JanKoehnlein commented Oct 4, 2021

roboquat commented Oct 4, 2021

roboquat commented Oct 4, 2021

gtsiolis commented Oct 4, 2021 • edited Loading

laushinka commented Sep 30, 2021 •

edited

Loading

JanKoehnlein commented Oct 1, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Oct 1, 2021 •

edited

Loading

gtsiolis commented Oct 1, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

laushinka commented Oct 3, 2021 •

edited by werft-gitpod-dev-com bot

Loading

JanKoehnlein commented Oct 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Oct 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 4, 2021 •

edited

Loading