Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "connection: buffer messages until reconnect" #5935

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 29, 2021

Description

Reverts #5787 because of https://www.gitpodstatus.com/incidents/bptcrqdnw7sz

Related Issue(s)

How to test

Release Notes

[dashboard] fix accumulating websocket connections

@geropl geropl changed the title Gpl/revert 5787 Revert "connection: buffer messages until reconnect" Sep 29, 2021
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6cf2a6a4d113b07511415cbb1de60a0c9873521

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #5787

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5a134c6 into main Sep 29, 2021
@roboquat roboquat deleted the gpl/revert-5787 branch September 29, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants