Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Readme #5912

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Clean-up Readme #5912

merged 2 commits into from
Sep 29, 2021

Conversation

JohannesLandgraf
Copy link
Contributor

@JohannesLandgraf JohannesLandgraf commented Sep 28, 2021

Description

Cleaned up dead links and brushed Readme.

Release Notes

NONE

/werft no-preview

@roboquat
Copy link
Contributor

@JohannesLandgraf: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 27a74eff6ed24646b75a91de25fd745f3fe8733b

@JohannesLandgraf
Copy link
Contributor Author

/approve no-issue

@svenefftinge
Copy link
Member

svenefftinge commented Sep 29, 2021

/werft run

👍 started the job as gitpod-build-johanneslandgraf-readme-update.1

@JohannesLandgraf
Copy link
Contributor Author

/approve no-issue

@roboquat roboquat removed the lgtm label Sep 29, 2021
@aledbf
Copy link
Member

aledbf commented Sep 29, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, JohannesLandgraf, svenefftinge

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aledbf,svenefftinge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Sep 29, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac98f7f8d4ee0776c17574ce66d4bb2da9a83b10

@roboquat
Copy link
Contributor

@JohannesLandgraf: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member

aledbf commented Sep 29, 2021

/werft run

👍 started the job as gitpod-build-johanneslandgraf-readme-update.3

@roboquat roboquat merged commit 0065707 into main Sep 29, 2021
@roboquat roboquat deleted the JohannesLandgraf-readme-update branch September 29, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants