Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy prometheus configuration and remove ws-manager-bridge role #5828

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Fix proxy prometheus configuration and remove ws-manager-bridge role #5828

merged 4 commits into from
Sep 23, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 23, 2021 •
edited
Loading

Release Notes

[ws-manager-bridge] Remove duplicated roleRef in helm chart
[proxy] Configure prometheus metrics endpoint

@roboquat roboquat requested a review from csweichel September 23, 2021 10:17
@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-errorf.6

@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-errorf.7

@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-errorf.9

@roboquat roboquat added size/M and removed size/XS labels Sep 23, 2021
@aledbf aledbf changed the title [ws-manager-bridge] Remove duplicated roleRef Fix prroxy prometheus configuration and remove ws-manager-bridge role Sep 23, 2021
@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2021

/assign @csweichel

@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2021

/approve no-issue

@aledbf aledbf changed the title Fix prroxy prometheus configuration and remove ws-manager-bridge role Fix proxy prometheus configuration and remove ws-manager-bridge role Sep 23, 2021
@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1041144ecb296ead2ca303e7a7746ba3d5afe106

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit e9bc08a into main Sep 23, 2021
@roboquat roboquat deleted the aledbf/errorf branch September 23, 2021 12:54
@laushinka laushinka mentioned this pull request Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel Awaiting requested review from csweichel

Assignees

@csweichel csweichel

Labels
approved release-note size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @csweichel @roboquat