-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager-bridge] Add status update metric #5755
Conversation
/cc @ArthurSens @geropl |
@@ -39,6 +40,11 @@ export class PrometheusMetricsExporter { | |||
help: 'Cordoned status of the individual registered workspace cluster', | |||
labelNames: ["workspace_cluster"] | |||
}); | |||
this.statusUpdatesTotal = new prom.Counter({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/werft run 👍 started the job as gitpod-build-cw-fix-5754.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested: 👍
LGTM label has been added. Git tree hash: 403592f24041ce83008e2eba71cfdd1c2ac39444
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geropl Associated issue: #5754 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds a metric that counts the total status updates we've received from a workspace cluster.
Related Issue(s)
Fixes #5754
How to test
gitpod_ws_manager_bridge_status_updates_total
Shoud look something like this:
Release Notes