Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager-bridge] Add status update metric #5755

Merged
merged 1 commit into from
Sep 20, 2021
Merged

[ws-manager-bridge] Add status update metric #5755

merged 1 commit into from
Sep 20, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Sep 18, 2021

Description

This PR adds a metric that counts the total status updates we've received from a workspace cluster.

Related Issue(s)

Fixes #5754

How to test

  1. Start a workspace
  2. Check the ws-manager-bridge metrics and find gitpod_ws_manager_bridge_status_updates_total

Shoud look something like this:
image

Release Notes

[ws-manager-bridge] Introduce `gitpod_ws_manager_bridge_status_updates_total` metric to monitor workspace cluster stability

@csweichel
Copy link
Contributor Author

/cc @ArthurSens @geropl

@@ -39,6 +40,11 @@ export class PrometheusMetricsExporter {
help: 'Cordoned status of the individual registered workspace cluster',
labelNames: ["workspace_cluster"]
});
this.statusUpdatesTotal = new prom.Counter({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geropl
Copy link
Member

geropl commented Sep 20, 2021

/werft run

👍 started the job as gitpod-build-cw-fix-5754.1

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested: 👍

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 403592f24041ce83008e2eba71cfdd1c2ac39444

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue: #5754

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b031cf3 into main Sep 20, 2021
@roboquat roboquat deleted the cw/fix-5754 branch September 20, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-manager-bridge] Export status update received metric
3 participants