Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parisng of tasks env vars in go #5719

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 16, 2021

Description

Our gitpod protocol schema allows any as a type for env vars of tasks. This PR adjusts typings to respect it in the code.
We considered also to make the scheme more strict, but it will be a breaking change, and there is no apparent downside of any value given that clients expect that the value be serialized/deserialized as JSON.

Related Issue(s)

fix #5699

How to test

Release Notes

Fix parsing of tasks' env vars.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #5719 (992a856) into main (a079bc4) will increase coverage by 0.57%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5719      +/-   ##
==========================================
+ Coverage   37.41%   37.98%   +0.57%     
==========================================
  Files          18       16       -2     
  Lines        4298     4136     -162     
==========================================
- Hits         1608     1571      -37     
+ Misses       2566     2439     -127     
- Partials      124      126       +2     
Flag Coverage Δ
components-local-app-app-linux ?
components-local-app-app-windows ?
components-supervisor-app 37.98% <62.50%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/config.go 4.51% <ø> (ø)
components/supervisor/pkg/supervisor/tasks.go 58.71% <62.50%> (+0.64%) ⬆️
components/supervisor/pkg/ports/ports.go 61.09% <0.00%> (-1.41%) ⬇️
components/supervisor/pkg/terminal/terminal.go 63.27% <0.00%> (-0.93%) ⬇️
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a079bc4...992a856. Read the comment docs.

@akosyakov akosyakov force-pushed the akosyakov/gitpod-yml-tasks-not-5699 branch from ed64bfe to 4a3ae28 Compare September 16, 2021 10:35
@akosyakov akosyakov force-pushed the akosyakov/gitpod-yml-tasks-not-5699 branch from 4a3ae28 to 992a856 Compare September 16, 2021 11:05
@akosyakov akosyakov marked this pull request as ready for review September 16, 2021 11:24
@akosyakov
Copy link
Member Author

/assign @geropl @jeanp413

@jeanp413
Copy link
Member

jeanp413 commented Sep 17, 2021

/werft run

👍 started the job as gitpod-build-akosyakov-gitpod-yml-tasks-not-5699.3

Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat added the lgtm label Sep 17, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: c00fea839c25beb1a97227d65278ca2fb87f90e4

@JanKoehnlein
Copy link
Contributor

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein, jeanp413

Associated issue: #5699

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit afd2cb3 into main Sep 17, 2021
@roboquat roboquat deleted the akosyakov/gitpod-yml-tasks-not-5699 branch September 17, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitpod.yml tasks not running
5 participants