-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parisng of tasks env vars in go #5719
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5719 +/- ##
==========================================
+ Coverage 37.41% 37.98% +0.57%
==========================================
Files 18 16 -2
Lines 4298 4136 -162
==========================================
- Hits 1608 1571 -37
+ Misses 2566 2439 -127
- Partials 124 126 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ed64bfe
to
4a3ae28
Compare
4a3ae28
to
992a856
Compare
/werft run 👍 started the job as gitpod-build-akosyakov-gitpod-yml-tasks-not-5699.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: c00fea839c25beb1a97227d65278ca2fb87f90e4
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JanKoehnlein, jeanp413 Associated issue: #5699 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Our gitpod protocol schema allows any as a type for env vars of tasks. This PR adjusts typings to respect it in the code.
We considered also to make the scheme more strict, but it will be a breaking change, and there is no apparent downside of any value given that clients expect that the value be serialized/deserialized as JSON.
Related Issue(s)
fix #5699
How to test
printenv PIP_USER
should befalse
.Release Notes