Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default branch label colors for dark theme #5556

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Sep 6, 2021

Description

This will add color support for dark theme for the default branch label, following the label specs used in #4607.

BEFORE AFTER
label-before label-after

How to test

  1. Enable Teams & Projects by going to /new.
  2. Add a project using GitLab provider since GitHub integration is not ready to use in preview environments.
  3. Once you add a project, go to Branches for that project. Make sure there's a default branch with at least one commit.

Release Notes

Change default branch label colors for dark theme

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 7, 2021

Hey @AlexTugarev! Could you take a look at this minor change since you initially added this label in #4970? 🏀

@AlexTugarev
Copy link
Member

AlexTugarev commented Sep 7, 2021

/werft run

👍 started the job as gitpod-build-gt-change-default-branch-label-colors.1

@AlexTugarev
Copy link
Member

AlexTugarev commented Sep 7, 2021

Change looks good! 🙏🏻

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Sep 7, 2021

LGTM label has been added.

Git tree hash: 2c256796ef180f89ed4ce4fb35f5cbc11f1f000d

@AlexTugarev
Copy link
Member

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5081bac into main Sep 7, 2021
@roboquat roboquat deleted the gt/change-default-branch-label-colors branch September 7, 2021 12:55
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 7, 2021

Danke @AlexTugarev! 🏓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants