Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Remove gitpod_ws_daemon_workspace_cpu_limit_sec metric #5444

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 30, 2021

fixes #5443

@roboquat roboquat requested a review from csweichel August 30, 2021 17:20
@aledbf
Copy link
Member Author

aledbf commented Aug 30, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #5444 (67455a4) into main (4044baf) will increase coverage by 22.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5444       +/-   ##
=========================================
+ Coverage      0   22.53%   +22.53%     
=========================================
  Files         0       11       +11     
  Lines         0     1930     +1930     
=========================================
+ Hits          0      435      +435     
- Misses        0     1437     +1437     
- Partials      0       58       +58     
Flag Coverage Δ
components-ws-daemon-app 22.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/resources/controller.go 31.06% <ø> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 46.71% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 58.88% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4044baf...67455a4. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 31, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8adcbd0a5e82f478cc9bfe0c2fb9294016e10aa8

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5443

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 71f32c4 into main Aug 31, 2021
@roboquat roboquat deleted the aledbf/rm branch August 31, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gitpod_ws_daemon_workspace_cpu_limit_sec metric
3 participants