Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Allow team members (and everyone in legacy mode) to access prebuilds #5433

Merged
merged 3 commits into from
Aug 31, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[server] Re-introduce access guard on resolvePlugins
  • Loading branch information
jankeromnes committed Aug 31, 2021
commit 259240d693166889c7d52165d144070fcedcd082
1 change: 1 addition & 0 deletions components/server/src/workspace/gitpod-server-impl.ts
Original file line number Diff line number Diff line change
@@ -1679,6 +1679,7 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod
this.checkUser("resolvePlugins")

const workspace = await this.internalGetWorkspace(workspaceId, this.workspaceDb.trace({}));
await this.guardAccess({ kind: "workspace", subject: workspace }, "get");
const result = await this.pluginService.resolvePlugins(workspace.ownerId, params);
return result.resolved;
};