-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'type' label to workspace stop metric #5423
Conversation
Signed-off-by: ArthurSens <[email protected]>
/werft run 👍 started the job as gitpod-build-as-ws-stop-metric.1 |
/werft run 👍 started the job as gitpod-build-as-ws-stop-metric.2 |
/werft run 👍 started the job as gitpod-build-as-ws-stop-metric.3 |
Codecov Report
@@ Coverage Diff @@
## main #5423 +/- ##
===========================================
+ Coverage 22.98% 38.35% +15.36%
===========================================
Files 11 13 +2
Lines 1945 3773 +1828
===========================================
+ Hits 447 1447 +1000
- Misses 1439 2202 +763
- Partials 59 124 +65
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/lgtm |
LGTM label has been added. Git tree hash: d1a5055fbae81377ff7fe86a74672481a595f06a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This label is necessary for our future SLO "If a workspace starts, it should remain running until it times out or is stopped by the user". The SLO will only care about regular workspaces, not ghosts, prebuilds nor imagebuilds