Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'type' label to workspace stop metric #5423

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Add 'type' label to workspace stop metric #5423

merged 1 commit into from
Aug 30, 2021

Conversation

ArthurSens
Copy link
Contributor

This label is necessary for our future SLO "If a workspace starts, it should remain running until it times out or is stopped by the user". The SLO will only care about regular workspaces, not ghosts, prebuilds nor imagebuilds

@roboquat roboquat requested a review from csweichel August 27, 2021 16:07
@ArthurSens
Copy link
Contributor Author

ArthurSens commented Aug 27, 2021

/werft run

👍 started the job as gitpod-build-as-ws-stop-metric.1

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Aug 27, 2021

/werft run

👍 started the job as gitpod-build-as-ws-stop-metric.2

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Aug 27, 2021

/werft run

👍 started the job as gitpod-build-as-ws-stop-metric.3

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #5423 (019de34) into main (4f9aa60) will increase coverage by 15.36%.
The diff coverage is 73.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5423       +/-   ##
===========================================
+ Coverage   22.98%   38.35%   +15.36%     
===========================================
  Files          11       13        +2     
  Lines        1945     3773     +1828     
===========================================
+ Hits          447     1447     +1000     
- Misses       1439     2202      +763     
- Partials       59      124       +65     
Flag Coverage Δ
components-ws-daemon-app ?
components-ws-manager-app 38.35% <73.58%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/manager_ee.go 0.00% <ø> (ø)
components/ws-manager/pkg/manager/metrics.go 11.26% <33.33%> (ø)
components/ws-manager/pkg/manager/monitor.go 8.36% <40.00%> (ø)
components/ws-manager/pkg/manager/status.go 73.33% <100.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go
components/ws-daemon/pkg/content/initializer.go
components/ws-daemon/pkg/content/service.go
components/ws-daemon/pkg/content/archive.go
components/ws-daemon/pkg/resources/dispatch.go
components/ws-daemon/pkg/content/config.go
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e039c1b...019de34. Read the comment docs.

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Aug 27, 2021

The new label is present and looks correct!

image

However, I did not started and stopped 8 workspaces 🤔. The number looks very incorrect

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1a5055fbae81377ff7fe86a74672481a595f06a

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 3e108e3 into main Aug 30, 2021
@roboquat roboquat deleted the as/ws-stop-metric branch August 30, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants