-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gitlab] Accept '#' sign in branches / context URLs #5362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was in the neighborhood and tried this in action! Works well for both GL and GH. ✔️
"defaultBranch": "master", | ||
"private": false | ||
}, | ||
"title": "gp-test-group/gp-test-project - feature/#123-issue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Shall we move this group under gitpod-io
group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely would love it if we would create proper repos for all these (and the GH) tests under the gitpod-io
group. For the sake of MVP what do you think of creating an issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely would love it if we would create proper repos for all these (and the GH) tests under the gitpod-io group. For the sake of MVP what do you think of creating an issue for that?
💯 x 💯
/auto-cc |
/werft run 👍 started the job as gitpod-build-clu-workspace-creation-5129.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested and works: 👍
LGTM label has been added. Git tree hash: 872cf4bc4684e8653b85ee5f1adcc9fea8e76754
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geropl Associated issue: #5129 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow to open GitLab branches with
#
sign (encoded as%23
).Test with: https://clu-workspace-creation-5129.staging.gitpod-dev.com/#https://gitlab.com/gp-test-group/gp-test-project/-/tree/issue-%23123
Fixes #5129